tools: update ESLint to 7.0.0-rc.0 - #33062
Conversation
Sorry, something went wrong.
Sorry, something went wrong.
trivikr
left a comment
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
|
unfortunately, I cannot use git-node to land PR for now, cause it does not support system proxy 😟 |
Sorry, something went wrong.
|
@targos It is caused by ISP issues, I usually just switch to another ISP (e.g. tethering through my phone because my mobile ISP blocks less), or use VPN on my computer. For git commands, git takes global proxy settings through ~/.gitconfig but git-node also have usual HTTPS requests to GitHub - these are not blocked the same way, some times connections to GitHub's git servers work while connections to some parts of github.com don't. Some people use tools like https://www.proxifier.com/ to redirect all TCP/UDP traffic in the system through a SOCKS5 server (I have not tried it). I guess we can also try adding proxy support to git-node (I see that there is already a feature request nodejs/node-core-utils#407) |
Sorry, something went wrong.
PR-URL: #33062 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #33062 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #33062 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #33062 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
I mostly wanted to update eslint, cause this's my first time.
Using update-eslint.sh, I think I've well done this
Checklist