FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix markdown parsing on doc/api/os.md by juanarbol · Pull Request #33067 · nodejs/node · GitHub

/ node Public

doc: fix markdown parsing on doc/api/os.md - #33067

Closed
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:juanarbol/fix-osversion-docs
Closed

doc: fix markdown parsing on doc/api/os.md#33067
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:juanarbol/fix-osversion-docs

Conversation

Copy link
Copy Markdown
Member

Something is wrong on MD parsing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. labels Apr 25, 2020

rexagod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems a bit odd. Was this due to an invalid character?

juanarbol commented Apr 27, 2020
edited
Loading

Copy link
Copy Markdown
Member Author

It looks like, I guess it is something with my code editor and space character, this had happened to me few times.

For this fix, I have built docs and check that fixed now.

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but it might be worth investigating why a nbsp breaks this, it really shouldn’t do that

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 27, 2020
addaleax pushed a commit that referenced this pull request Apr 29, 2020
PR-URL: #33067
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Copy link
Copy Markdown
Member

Landed in ed87433

addaleax closed this Apr 29, 2020
targos pushed a commit that referenced this pull request May 4, 2020
PR-URL: #33067
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request May 4, 2020
juanarbol deleted the juanarbol/fix-osversion-docs branch January 19, 2021 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL