stream: Duplex re-use Writable properties - #33079
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ronag
force-pushed
the
duplex-refacfor-properties
branch
from
5b199fa to
0877fea
Compare
April 26, 2020 17:44
Instead of reimplementing Writable properties, fetch them from the Writable prototype.
ronag
force-pushed
the
duplex-refacfor-properties
branch
from
0877fea to
f5c7fb3
Compare
April 26, 2020 17:45
juanarbol
approved these changes
Apr 26, 2020
juanarbol
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Apr 27, 2020
lpinca
approved these changes
Apr 27, 2020
addaleax
approved these changes
Apr 27, 2020
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31017/ (:yellow_heart:) |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Apr 29, 2020
Instead of reimplementing Writable properties, fetch them from the Writable prototype. PR-URL: #33079 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 4, 2020
Instead of reimplementing Writable properties, fetch them from the Writable prototype. PR-URL: #33079 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of reimplementing Writable properties, fetch them
from the Writable prototype.
Checklist