FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: made grammar more consistent and correct by ChrisAHolland · Pull Request #33081 · nodejs/node · GitHub

/ node Public

doc: made grammar more consistent and correct - #33081

Closed
ChrisAHolland wants to merge 1 commit into
nodejs:masterfrom
ChrisAHolland:master
ConversationCommits (1)ChecksFiles changed
Closed

doc: made grammar more consistent and correct#33081
ChrisAHolland wants to merge 1 commit into
nodejs:masterfrom
ChrisAHolland:master

Conversation

ChrisAHolland commented Apr 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This file contained a few grammatical mistakes and inconsistencies. This pull request makes those simple fixes. Reopening of #32957 after I accidentally deleted the branch.

Checklist

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 26, 2020
ChrisAHolland mentioned this pull request Apr 26, 2020
Closed
rexagod approved these changes Apr 27, 2020
View reviewed changes

rexagod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

juanarbol approved these changes Apr 27, 2020
View reviewed changes

juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is great! Thank you so much for your contribution.

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 27, 2020
Trott reviewed Apr 28, 2020
View reviewed changes
Comment thread doc/guides/backporting-to-release-lines.md
1. Checkout the staging branch for the targeted release line
2. Make sure that the local staging branch is up to date with the remote
3. Create a new branch off of the staging branch
1. Checkout the staging branch for the targeted release line.

Trott Apr 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

While we're in here, maybe this too?

Suggested change
1. Checkout the staging branch for the targeted release line.
1. Check out the staging branch for the targeted release line.

ChrisAHolland Apr 28, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are we sure we'd want to change this considering it's in reference to the git checkout command?

addaleax Apr 29, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I’ll go ahead with landing this as this PR hasn’t modified that part.

Trott approved these changes Apr 28, 2020
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with or without my suggestion

addaleax pushed a commit that referenced this pull request Apr 29, 2020
doc: some grammar fixes
a9b8f70 
PR-URL: #33081
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax commented Apr 29, 2020

Copy link
Copy Markdown
Member

Landed in a9b8f70, thanks for the PR!

addaleax closed this Apr 29, 2020
targos pushed a commit that referenced this pull request May 4, 2020
doc: some grammar fixes
289a5c8 
PR-URL: #33081
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
doc: some grammar fixes
6782b1d 
PR-URL: #33081
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
doc: some grammar fixes
90cf886 
PR-URL: #33081
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
Trott Trott approved these changes
juanarbol juanarbol approved these changes
+1 more reviewer
rexagod rexagod approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL