fs: add .ref() and .unref() methods to the StatWatcher and FSWatcher by rickyes · Pull Request #33134 · nodejs/node · GitHub

add .ref() and .unref() methods to the StatWatcher and FSWatcher classes.

Fixes: #33096

/cc @addaleax

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

…classes

These methods should probably also be documented for the return value of .watchFile().

OK, there are other methods like .stop(), I'm not sure if it should be documented in this PR.

fixed

@addaleax @jasnell I've made some new ones. Please review.

CI: https://ci.nodejs.org/job/node-test-pull-request/31223/

PR-URL: #33134 Fixes: #33096 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Landed in be7fd2d :)

PR-URL: #33134 Fixes: #33096 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Notable changes: async_hooks: * (SEMVER-MINOR) move PromiseHook handler to JS (Stephen Belanger) #32891 cli: * (SEMVER-MINOR) add `--trace-atomics-wait` flag (Anna Henningsen) #33292 fs: * (SEMVER-MINOR) add .ref() and .unref() methods to watcher classes (rickyes) #33134 http: * (SEMVER-MINOR) expose http.validate-header-name/value (osher) #33119 repl: * (SEMVER-MINOR) deprecate repl._builtinLibs (Ruben Bridgewater) #33294 * (SEMVER-MINOR) remove obsolete completer variable (Ruben Bridgewater) #33294 * (SEMVER-MINOR) deprecate repl.inputStream and repl.outputStream (Ruben Bridgewater) #33294 * (SEMVER-MINOR) improve repl autocompletion for require calls (Ruben Bridgewater) #33282 * (SEMVER-MINOR) replace hard coded core module list with actual list (Ruben Bridgewater) #33282 * (SEMVER-MINOR) show reference errors during preview (Ruben Bridgewater) #33282 * (SEMVER-MINOR) improve repl preview (Ruben Bridgewater) #33282 src: * add support for TLA (Gus Caplan) #30370 test: * (SEMVER-MINOR) refactor test/parallel/test-bootstrap-modules.js (Ruben Bridgewater) #33282 PR-URL: TODO

Notable changes: async_hooks: * (SEMVER-MINOR) move PromiseHook handler to JS (Stephen Belanger) #32891 cli: * (SEMVER-MINOR) add `--trace-atomics-wait` flag (Anna Henningsen) #33292 fs: * (SEMVER-MINOR) add .ref() and .unref() methods to watcher classes (rickyes) #33134 http: * (SEMVER-MINOR) expose http.validate-header-name/value (osher) #33119 repl: * (SEMVER-MINOR) deprecate repl._builtinLibs (Ruben Bridgewater) #33294 * (SEMVER-MINOR) deprecate repl.inputStream and repl.outputStream (Ruben Bridgewater) #33294 * (SEMVER-MINOR) show reference errors during preview (Ruben Bridgewater) #33282 * (SEMVER-MINOR) improve repl preview (Ruben Bridgewater) #33282 src: * add support for TLA (Gus Caplan) #30370 PR-URL: TODO

PR-URL: nodejs/node#33134 Fixes: nodejs/node#33096 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

fs: add .ref() and .unref() methods to the StatWatcher and FSWatcher …

bb8580f

…classes

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Apr 28, 2020

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 28, 2020

addaleax reviewed Apr 28, 2020

View reviewed changes

jasnell reviewed Apr 28, 2020

View reviewed changes

Comment thread lib/internal/fs/watchers.js

jasnell reviewed Apr 28, 2020

View reviewed changes

Comment thread lib/internal/fs/watchers.js

jasnell reviewed Apr 28, 2020

View reviewed changes

Comment thread test/parallel/test-fs-watchfile-ref-unref.js Outdated

fs: Add unwatchFile to handle reference counting

5cb73d4

rickyes requested review from addaleax and jasnell April 29, 2020 07:46

jasnell reviewed Apr 30, 2020

View reviewed changes

Comment thread doc/api/fs.md

jasnell approved these changes Apr 30, 2020

View reviewed changes

doc: document the return value

9229123

addaleax approved these changes May 7, 2020

View reviewed changes

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 7, 2020

addaleax pushed a commit that referenced this pull request May 9, 2020

fs: add .ref() and .unref() methods to watcher classes

be7fd2d

PR-URL: #33134 Fixes: #33096 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax closed this May 9, 2020

rickyes deleted the add-unref-ref-in-fswatch branch May 9, 2020 06:00

codebytere pushed a commit that referenced this pull request May 11, 2020

fs: add .ref() and .unref() methods to watcher classes

1dcf66c

PR-URL: #33134 Fixes: #33096 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

codebytere mentioned this pull request May 18, 2020

v14.3.0 proposal #33452

Merged

This was referenced Aug 2, 2021

Update minor updates gatsby-uc/plugins#21

Closed

Update Node.js to >=v12.22.4 keystonejs/keystone#6241

Closed

gary-kim-bot mentioned this pull request Aug 2, 2021

chore(deps): update node.js to >=v12.22.4 gary-kim/nc-build-script#63

Open

1 task

renovate Bot mentioned this pull request Aug 3, 2021

Update Node.js to >=v12.22.4 Pytal/deploy-env#89

Merged

1 task

This was referenced Aug 11, 2021

Update Node.js to v12.22.5 SirReiva/backend-mongo-express-jwt#48

Closed

Update Node.js to v12.22.12 - abandoned shaimael-ws-java-demo/mariadb#41

Open

Dmarch28 mentioned this pull request Jun 19, 2022

[Snyk] Fix for 1 vulnerabilities Dmarch28/node#61

Open

snyk-bot mentioned this pull request Jun 19, 2022

[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#61

Open

137717unity mentioned this pull request Jun 19, 2022

[Snyk] Fix for 1 vulnerabilities 137717unity/node#60

Open

baby636 mentioned this pull request Jun 19, 2022

[Snyk] Fix for 1 vulnerabilities baby636/node#58

Open

snyk-bot mentioned this pull request Jun 19, 2022

[Snyk] Fix for 1 vulnerabilities Rednickle/node-1#51

Open

kissofire mentioned this pull request Jun 19, 2022

[Snyk] Fix for 1 vulnerabilities kissofire/node#70

Open

snyk-bot mentioned this pull request Jun 19, 2022

[Snyk] Fix for 1 vulnerabilities wedataintelligence/node#36

Open

ron-a20 mentioned this pull request Jun 19, 2022

[Snyk] Fix for 1 vulnerabilities ron-a20/node#69

Open

molllyn1 mentioned this pull request Jun 20, 2022

[Snyk] Fix for 1 vulnerabilities molllyn1/node#51

Open

snyk-bot mentioned this pull request Jan 30, 2023

[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#89

Open

wedataintelligence mentioned this pull request Jan 30, 2023

[Snyk] Fix for 1 vulnerabilities wedataintelligence/node#73

Open

snyk-bot mentioned this pull request Jan 30, 2023

[Snyk] Fix for 1 vulnerabilities kissofire/node#94

Open

molllyn1 mentioned this pull request Jan 31, 2023

[Snyk] Fix for 1 vulnerabilities molllyn1/node#76

Open

snyk-bot mentioned this pull request Jan 31, 2023

[Snyk] Fix for 1 vulnerabilities 137717unity/node#93

Open

baby636 mentioned this pull request Jan 31, 2023

[Snyk] Fix for 1 vulnerabilities baby636/node#88

Open

This was referenced Jan 31, 2023

[Snyk] Fix for 1 vulnerabilities ron-a20/node#93

Open

[Snyk] Fix for 1 vulnerabilities Rednickle/node-1#70

Open

+              event loop to remain active. If there is no other activity keeping the
+              event loop running, the process may exit before the `FSWatcher` object's
+              callback is invoked. Calling `watcher.unref()` multiple times will have
+              no effect.

fs: add .ref() and .unref() methods to the StatWatcher and FSWatcher by rickyes · Pull Request #33134 · nodejs/node · GitHub

Uh oh!

Uh oh!

fs: add .ref() and .unref() methods to the StatWatcher and FSWatcher - #33134

fs: add .ref() and .unref() methods to the StatWatcher and FSWatcher#33134
rickyes wants to merge 3 commits into
nodejs:masterfrom
rickyes:add-unref-ref-in-fswatch

rickyes commented Apr 28, 2020

Uh oh!

Uh oh!

addaleax Apr 28, 2020

Uh oh!

rickyes Apr 28, 2020

Uh oh!

rickyes Apr 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rickyes commented Apr 30, 2020

Uh oh!

Uh oh!

nodejs-github-bot commented May 7, 2020

Uh oh!

addaleax commented May 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fs: add .ref() and .unref() methods to the StatWatcher and FSWatcher by rickyes · Pull Request #33134 · nodejs/node · GitHub

Uh oh!

Uh oh!

fs: add .ref() and .unref() methods to the StatWatcher and FSWatcher - #33134

fs: add .ref() and .unref() methods to the StatWatcher and FSWatcher#33134rickyes wants to merge 3 commits intonodejs:masternodejs/node:masterfrom rickyes:add-unref-ref-in-fswatchrickyes/node:add-unref-ref-in-fswatchCopy head branch name to clipboard

Conversation

rickyes commented Apr 28, 2020

Checklist

Uh oh!

Uh oh!

addaleax Apr 28, 2020

Choose a reason for hiding this comment

Uh oh!

rickyes Apr 28, 2020

Choose a reason for hiding this comment

Uh oh!

rickyes Apr 29, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rickyes commented Apr 30, 2020

Uh oh!

Uh oh!

nodejs-github-bot commented May 7, 2020

Uh oh!

addaleax commented May 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fs: add .ref() and .unref() methods to the StatWatcher and FSWatcher#33134
rickyes wants to merge 3 commits into
nodejs:masterfrom
rickyes:add-unref-ref-in-fswatch