FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

module: lazy load 'getOptionValue' in initializeLoader by himself65 · Pull Request #33212 · nodejs/node · GitHub

/ node Public

module: lazy load 'getOptionValue' in initializeLoader - #33212

Closed
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200502-module-getOptionValue
ConversationCommits (1)ChecksFiles changed
Closed

module: lazy load 'getOptionValue' in initializeLoader#33212
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200502-module-getOptionValue

Conversation

himself65 commented May 2, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the process Issues and PRs related to the process subsystem. label May 2, 2020

nodejs-github-bot commented May 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31142/

juanarbol requested a review from guybedford May 4, 2020 02:59

HarshithaKP commented May 4, 2020

Copy link
Copy Markdown
Member

@himself65, can you please explain why this change is made ?

addaleax approved these changes May 4, 2020
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

If nothing else, this enables loading this module during early bootstrapping

himself65 commented May 4, 2020

Copy link
Copy Markdown
Member Author

@himself65, can you please explain why this change is made ?

addaleax has said what I wanna say

nodejs-github-bot commented May 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31162/

nodejs-github-bot commented May 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31163/

himself65 self-assigned this May 6, 2020

nodejs-github-bot commented May 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31185/

nodejs-github-bot commented May 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31187/

nodejs-github-bot commented May 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31188/

richardlau commented May 6, 2020

Copy link
Copy Markdown
Member

If nothing else, this enables loading this module during early bootstrapping

If whoever lands this could add some words to the commit description paraphrasing the above (the "why this is being done") it would be very helpful for anyone browsing through commit history later on.

nodejs-github-bot commented May 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31189/

nodejs-github-bot commented May 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31190/

nodejs-github-bot commented May 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31198/

nodejs-github-bot commented May 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31200/

nodejs-github-bot commented May 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31201/

nodejs-github-bot commented May 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31202/

nodejs-github-bot commented May 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31203/

addaleax pushed a commit that referenced this pull request May 7, 2020
module: lazy load 'getOptionValue' in initializeLoader
f153081 
This enables loading this module during early bootstrapping.

PR-URL: #33212
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

addaleax commented May 7, 2020

Copy link
Copy Markdown
Member

Landed in f153081

addaleax closed this May 7, 2020
codebytere pushed a commit that referenced this pull request May 11, 2020
module: lazy load 'getOptionValue' in initializeLoader
27b814c 
This enables loading this module during early bootstrapping.

PR-URL: #33212
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere mentioned this pull request May 18, 2020
Merged

codebytere commented Jun 7, 2020

Copy link
Copy Markdown
Member

@himself65 this change can't currently apply to v12.x since a6b030d was landed with alterations on the v12.x branch: 02c4d27.

I'm going to tag it for now with dont-land but if you feel like trying to make it work you're welcome to :)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
guybedford guybedford approved these changes
addaleax addaleax approved these changes
richardlau richardlau approved these changes

Assignees

himself65

Labels

process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL