FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

buffer: improve copy() performance by seishun · Pull Request #33214 · nodejs/node · GitHub

/ node Public

buffer: improve copy() performance - #33214

Closed
seishun wants to merge 2 commits into
nodejs:masterfrom
seishun:buffer-copy-perf
ConversationCommits (2)ChecksFiles changed
Closed

buffer: improve copy() performance#33214
seishun wants to merge 2 commits into
nodejs:masterfrom
seishun:buffer-copy-perf

Conversation

seishun commented May 2, 2020

Copy link
Copy Markdown
Contributor

There is no need to create a slice when sourceEnd is out of bounds.

Results of included benchmark:

                                                                           confidence improvement accuracy (*)     (**)    (***)
 buffers\\buffer-copy.js n=6000000 oob='false' partial='false' bytes=0                     3.30 %      ±4.96%  ±6.62%  ±8.65%
 buffers\\buffer-copy.js n=6000000 oob='false' partial='false' bytes=128                  -0.66 %      ±3.54%  ±4.71%  ±6.13%
 buffers\\buffer-copy.js n=6000000 oob='false' partial='false' bytes=32768                -3.02 %      ±8.44% ±11.30% ±14.83%
 buffers\\buffer-copy.js n=6000000 oob='false' partial='false' bytes=8                     2.80 %      ±5.54%  ±7.37%  ±9.61%
 buffers\\buffer-copy.js n=6000000 oob='false' partial='true' bytes=0                      2.29 %      ±4.58%  ±6.10%  ±7.98%
 buffers\\buffer-copy.js n=6000000 oob='false' partial='true' bytes=128                    1.90 %      ±3.39%  ±4.52%  ±5.88%
 buffers\\buffer-copy.js n=6000000 oob='false' partial='true' bytes=32768                  0.23 %      ±7.59% ±10.10% ±13.16%
 buffers\\buffer-copy.js n=6000000 oob='false' partial='true' bytes=8                      2.75 %      ±4.06%  ±5.42%  ±7.07%
 buffers\\buffer-copy.js n=6000000 oob='true' partial='false' bytes=0                      2.68 %      ±4.89%  ±6.52%  ±8.50%
 buffers\\buffer-copy.js n=6000000 oob='true' partial='false' bytes=128           ***    135.43 %      ±7.70% ±10.31% ±13.57%
 buffers\\buffer-copy.js n=6000000 oob='true' partial='false' bytes=32768           *      5.98 %      ±4.85%  ±6.46%  ±8.40%
 buffers\\buffer-copy.js n=6000000 oob='true' partial='false' bytes=8             ***    142.55 %     ±10.22% ±13.71% ±18.06%
 buffers\\buffer-copy.js n=6000000 oob='true' partial='true' bytes=0                       4.42 %      ±4.67%  ±6.26%  ±8.23%
 buffers\\buffer-copy.js n=6000000 oob='true' partial='true' bytes=128                     0.66 %      ±2.75%  ±3.66%  ±4.77%
 buffers\\buffer-copy.js n=6000000 oob='true' partial='true' bytes=32768                  -1.10 %      ±7.26%  ±9.67% ±12.59%
 buffers\\buffer-copy.js n=6000000 oob='true' partial='true' bytes=8                       2.74 %      ±3.92%  ±5.23%  ±6.82%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

buffer: improve copy() performance
3aa630d 
There is no need to create a slice when sourceEnd is out of bounds.
nodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label May 2, 2020
seishun requested a review from mscdex May 2, 2020 17:39
BridgeAR reviewed May 3, 2020
View reviewed changes
Comment thread benchmark/buffers/buffer-copy.js Outdated
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 7, 2020

nodejs-github-bot commented May 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31218/

addaleax pushed a commit that referenced this pull request May 9, 2020
buffer: improve copy() performance
339690c 
There is no need to create a slice when sourceEnd is out of bounds.

PR-URL: #33214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax commented May 9, 2020

Copy link
Copy Markdown
Member

Landed in 339690c

addaleax closed this May 9, 2020
seishun deleted the buffer-copy-perf branch May 9, 2020 14:06
codebytere pushed a commit that referenced this pull request May 11, 2020
buffer: improve copy() performance
cae2051 
There is no need to create a slice when sourceEnd is out of bounds.

PR-URL: #33214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
buffer: improve copy() performance
964adfa 
There is no need to create a slice when sourceEnd is out of bounds.

PR-URL: #33214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere mentioned this pull request Jun 9, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BridgeAR BridgeAR left review comments
addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
himself65 himself65 approved these changes
mscdex Awaiting requested review from mscdex

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL