doc: doc and test URLSearchParams discrepancy - #33236
Closed
jasnell wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: nodejs#33037
lpinca
approved these changes
May 4, 2020
Trott
reviewed
May 5, 2020
Comment thread
doc/api/url.md
Outdated
Trott
reviewed
May 5, 2020
Comment thread
doc/api/url.md
Outdated
Trott
reviewed
May 5, 2020
Comment thread
doc/api/url.md
Outdated
Trott
approved these changes
May 5, 2020
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, although I'd prefer it with the suggestions I left. But they are not mandatory or blocking or anything.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@Trott ... Please feel free to apply the changes if you'd like. |
Sorry, something went wrong.
joyeecheung
approved these changes
May 5, 2020
himself65
approved these changes
May 5, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
May 6, 2020
The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #33037 PR-URL: #33236 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Copy link
Copy Markdown
Member
Author
|
@nodejs/tsc ... Sorry for the quick force push on master... originally landed without the metadata. Caught it within the five minute window |
Sorry, something went wrong.
codebytere
pushed a commit
that referenced
this pull request
May 7, 2020
The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #33037 PR-URL: #33236 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #33037 PR-URL: #33236 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WHATWG URL spec is not going to change this behavior so
let's document it
Fixes: #33037
Checklist