FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: Replace checkPosition with validateInteger by rickyes · Pull Request #33277 · nodejs/node · GitHub

/ node Public

fs: Replace checkPosition with validateInteger - #33277

Closed
rickyes wants to merge 2 commits into
nodejs:masterfrom
rickyes:refactor-checkPosition
ConversationCommits (2)ChecksFiles changed
Closed

fs: Replace checkPosition with validateInteger#33277
rickyes wants to merge 2 commits into
nodejs:masterfrom
rickyes:refactor-checkPosition

Conversation

rickyes commented May 7, 2020

Copy link
Copy Markdown
Contributor

/cc @ZYSzys

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label May 7, 2020
HarshithaKP reviewed May 7, 2020
View reviewed changes
Comment thread test/parallel/test-file-write-stream3.js Outdated
HarshithaKP reviewed May 7, 2020
View reviewed changes
Comment thread test/parallel/test-file-write-stream3.js Outdated

nodejs-github-bot commented May 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31238/

rickyes commented May 16, 2020

Copy link
Copy Markdown
Contributor Author

It's ready.

ZYSzys added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 17, 2020

addaleax commented May 20, 2020

Copy link
Copy Markdown
Member

@rickyes Could you rebase this against master?

addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 20, 2020

rickyes commented May 20, 2020

Copy link
Copy Markdown
Contributor Author

@rickyes Could you rebase this against master?

done

rickyes commented May 21, 2020

Copy link
Copy Markdown
Contributor Author

ping @addaleax . A check being canceled does not seem to be related to this PR.

addaleax commented May 21, 2020

Copy link
Copy Markdown
Member

@rickyes This still needs to be rebased using git rebase – git merge doesn’t work for our CI.

Let me know if you’d prefer that somebody else does that, that’s no problem.

rickyes force-pushed the refactor-checkPosition branch from 6176ad5 to 5db3f25 Compare May 21, 2020 09:46

rickyes commented May 21, 2020

Copy link
Copy Markdown
Contributor Author

@rickyes This still needs to be rebased using git rebase – git merge doesn’t work for our CI.

Let me know if you’d prefer that somebody else does that, that’s no problem.

done

nodejs-github-bot commented May 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31460/

rickyes commented May 21, 2020

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/31460/

Looks like jenkinsci has a problem.
https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1015/34277/console

nodejs-github-bot commented May 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31462/

rickyes commented May 21, 2020

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/31462/

The green ci.

ZYSzys pushed a commit that referenced this pull request May 22, 2020
fs: replace checkPosition with validateInteger
49f549e 
PR-URL: #33277
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

ZYSzys commented May 22, 2020

Copy link
Copy Markdown
Member

Landed in 49f549e.

ZYSzys closed this May 22, 2020
rickyes deleted the refactor-checkPosition branch May 22, 2020 01:53
codebytere pushed a commit that referenced this pull request Jun 18, 2020
fs: replace checkPosition with validateInteger
b675ea0 
PR-URL: #33277
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 8, 2020
fs: replace checkPosition with validateInteger
5fb1cc8 
PR-URL: #33277
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
codebytere mentioned this pull request Jul 13, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

HarshithaKP HarshithaKP left review comments
jasnell jasnell approved these changes
BridgeAR BridgeAR approved these changes
ZYSzys ZYSzys approved these changes

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL