FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v12.x] Disable headers timeout by ShogunPanda · Pull Request #33307 · nodejs/node · GitHub

/ node Public

[v12.x] Disable headers timeout - #33307

Closed
ShogunPanda wants to merge 4 commits into
nodejs:v12.x-stagingfrom
ShogunPanda:disable-headers-timeout
ConversationCommits (4)ChecksFiles changed
Closed

[v12.x] Disable headers timeout#33307
ShogunPanda wants to merge 4 commits into
nodejs:v12.x-stagingfrom
ShogunPanda:disable-headers-timeout

Conversation

ShogunPanda commented May 8, 2020

Copy link
Copy Markdown
Contributor

Setting headersTimeout to 0 does not disable the checks as expected but rather makes any request fail immediately.

This PR fixes the problem. This should also be backported to 10.x.
Node 13 and 14/master are fine since headersTimeout live now in HTTPParser which correctly checks for the value being greater than 0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added http Issues or PRs related to the http subsystem. v12.x labels May 8, 2020

benjamingr commented May 8, 2020

Copy link
Copy Markdown
Member

Hey thank you for your contribution, would you mind adding a test for this?

ShogunPanda commented May 8, 2020

Copy link
Copy Markdown
Contributor Author

Good point, I forgot. Will add it now!

ShogunPanda commented May 11, 2020

Copy link
Copy Markdown
Contributor Author

For some reason "now" became "3 days". :)
Anyway the test is there now!

benjamingr approved these changes May 11, 2020
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott commented May 11, 2020

Copy link
Copy Markdown
Member

I'm not 100% sure about this, but I think this needs to be opened against v12.x-staging rather than v12.x. (Someone else, please confirm!) @nodejs/releasers

targos commented May 11, 2020

Copy link
Copy Markdown
Member

I'm not 100% sure about this, but I think this needs to be opened against v12.x-staging rather than v12.x. (Someone else, please confirm!) @nodejs/releasers

That's correct

targos changed the title Disable headers timeout [v12.x] Disable headers timeout May 11, 2020
ShogunPanda changed the base branch from v12.x to v12.x-staging May 12, 2020 18:05

ShogunPanda commented May 12, 2020

Copy link
Copy Markdown
Contributor Author

@Trott @targos Sorry for the wrong branch. I've updated the PR to be open against v12.x-staging.

targos commented May 13, 2020

Copy link
Copy Markdown
Member

/cc @nodejs/http

BridgeAR commented May 23, 2020

Copy link
Copy Markdown
Member

@targos should this still be included in the next v12 release?

@nodejs/http @nodejs/http2 @nodejs/streams PTAL

nodejs-github-bot commented May 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31512/

mcollina commented May 23, 2020

Copy link
Copy Markdown
Member

I hope it would be included.

BridgeAR mentioned this pull request May 23, 2020
Merged
targos pushed a commit that referenced this pull request May 25, 2020
http: disable headersTimeout check when set to zero
ebd9090 
PR-URL: #33307
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos commented May 25, 2020

Copy link
Copy Markdown
Member

Landed in ebd9090. Thanks @ShogunPanda

targos closed this May 25, 2020
ShogunPanda deleted the disable-headers-timeout branch May 25, 2020 13:48
blushingpenguin mentioned this pull request Jun 24, 2020
Merged
richardlau pushed a commit that referenced this pull request Jul 2, 2020
http: disable headersTimeout check when set to zero
069b6e1 
PR-URL: #33307
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
richardlau mentioned this pull request Jul 2, 2020
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL