FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix compiler warning in async_wrap.cc by addaleax · Pull Request #33322 · nodejs/node · GitHub

/ node Public

src: fix compiler warning in async_wrap.cc - #33322

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:async-wrap-warning
ConversationCommits (1)ChecksFiles changed
Closed

src: fix compiler warning in async_wrap.cc#33322
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:async-wrap-warning

Conversation

addaleax commented May 9, 2020

Copy link
Copy Markdown
Member 
../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’:
../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Refs: #32891

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

src: fix compiler warning in async_wrap.cc
4cfbd58 
    ../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’:
    ../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type]
     }

Refs: nodejs#32891
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 9, 2020

nodejs-github-bot commented May 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31250/

addaleax commented May 9, 2020

Copy link
Copy Markdown
Member Author

👍 to fast-track?

addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label May 9, 2020
addaleax added a commit that referenced this pull request May 9, 2020
src: fix compiler warning in async_wrap.cc
ae34e47 
    ../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’:
    ../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type]
     }

Refs: #32891

PR-URL: #33322
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

addaleax commented May 9, 2020

Copy link
Copy Markdown
Member Author

Landed in ae34e47, thanks for the reviews!

addaleax closed this May 9, 2020
addaleax deleted the async-wrap-warning branch May 9, 2020 17:09

codebytere commented May 11, 2020

Copy link
Copy Markdown
Member

@addaleax should this be backported to v14.x? There's a conflict it seems - i can add the label if yes!

addaleax commented May 11, 2020

Copy link
Copy Markdown
Member Author

@codebytere It’s not important to be backported, but I’m surprised that it doesn’t apply after #32891… I can try to take a look later

codebytere commented May 11, 2020

Copy link
Copy Markdown
Member

@addaleax ah it looks like the linked pr has dont-land-on-v14.x so i didn't catch it in my branch-diff

addaleax commented May 11, 2020

Copy link
Copy Markdown
Member Author

@codebytere Only in the past – if running branch-diff now doesn’t catch it, then branch-diff is probably broken… the linked PR should land on v14.x, in any case.

codebytere commented May 11, 2020

Copy link
Copy Markdown
Member

Figured out the issue 😅applied now!

codebytere pushed a commit that referenced this pull request May 11, 2020
src: fix compiler warning in async_wrap.cc
fd9c7c2 
    ../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’:
    ../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type]
     }

Refs: #32891

PR-URL: #33322
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
codebytere mentioned this pull request May 18, 2020
Merged

codebytere commented Jun 7, 2020

Copy link
Copy Markdown
Member

Marking don't land as it affects code introduced in #32891.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL