FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update to ICU 67.1 by targos · Pull Request #33324 · nodejs/node · GitHub

/ node Public

deps: update to ICU 67.1 - #33324

Closed
targos wants to merge 2 commits into
nodejs:masterfrom
targos:icu-67.1
ConversationCommits (2)ChecksFiles changed
Closed

deps: update to ICU 67.1#33324
targos wants to merge 2 commits into
nodejs:masterfrom
targos:icu-67.1

Conversation

targos commented May 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

targos requested review from ryzokuken and srl295 May 9, 2020 11:43
ryzokuken approved these changes May 9, 2020
View reviewed changes

ryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

richardlau commented May 9, 2020

Copy link
Copy Markdown
Member

tools/icu/current_ver.dep should be updated: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-icu.md#how-to-upgrade-icu

targos commented May 9, 2020

Copy link
Copy Markdown
Member Author

Am I supposed to compute the md5 myself?

nodejs-github-bot commented May 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31253/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 9, 2020
srl295 approved these changes May 9, 2020
View reviewed changes

srl295 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

meta LGTM, code RSLGTM

srl295 commented May 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

in progress https://www.npmjs.com/package/icu4c-data

srl295 commented May 9, 2020

Copy link
Copy Markdown
Member

in progress https://www.npmjs.com/package/icu4c-data

I'm getting timeouts…again… trying to publish to npm. So it's not quite there.

codebytere commented May 11, 2020

Copy link
Copy Markdown
Member

@targos does this close nodejs/Release#576? It was assigned to me per the last release meeting so i want to make sure i'm not duplicating work.

targos commented May 11, 2020

Copy link
Copy Markdown
Member Author

@codebytere I don't know. I asked the same question to @srl295 (#33337 (comment)) 15 minutes ago 😄

srl295 commented May 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@targos does this close nodejs/Release#576? It was assigned to me per the last release meeting so i want to make sure i'm not duplicating work.

Ugh. did not see this, I could have incorporated this into the data.

No, that bug shows as fixed in 68 not 67.

targos added a commit that referenced this pull request May 12, 2020
deps: update to ICU 67.1
cfec30f 
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1

PR-URL: #33324
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>

targos commented May 12, 2020

Copy link
Copy Markdown
Member Author

Landed in cfec30f

targos closed this May 12, 2020
targos deleted the icu-67.1 branch May 12, 2020 07:58
targos added backport-open-v12.x and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels May 12, 2020
srl295 mentioned this pull request May 12, 2020
Closed
codebytere pushed a commit that referenced this pull request May 16, 2020
deps: update to ICU 67.1
331f0b3 
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1

PR-URL: #33324
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
codebytere mentioned this pull request May 18, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srl295 srl295 approved these changes
+1 more reviewer
ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL