FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix test-net-throttle by Trott · Pull Request #33329 · nodejs/node · GitHub

/ node Public

test: fix test-net-throttle - #33329

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:fix-test-net-throttle
May 11, 2020
ConversationCommits (1)ChecksFiles changed
Merged

test: fix test-net-throttle#33329
Trott merged 1 commit into
nodejs:masterfrom
Trott:fix-test-net-throttle

Conversation

Trott commented May 9, 2020

Copy link
Copy Markdown
Member

Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: #33135

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label May 9, 2020

Trott commented May 9, 2020

Copy link
Copy Markdown
Member Author

Relevant CI run is: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14181/

Pummel tests otherwise don't get run in CI, so only the linter and the above job are relevant.

Trott commented May 9, 2020

Copy link
Copy Markdown
Member Author

The test passed in CI. First time in something like two weeks!

Trott mentioned this pull request May 9, 2020
Closed
Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label May 9, 2020
lpinca approved these changes May 9, 2020
View reviewed changes
Comment thread test/pummel/test-net-throttle.js Outdated

Trott commented May 9, 2020

Copy link
Copy Markdown
Member Author

Re-running relevant CI post-fixup commit: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14184/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 10, 2020
Trott mentioned this pull request May 10, 2020
Closed
4 tasks

Trott commented May 10, 2020

Copy link
Copy Markdown
Member Author

This is basically the only thing that has kept node-daily-master from being green many days now.

Fast-track? 👍 here to approve if you're a Collaborator.

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label May 10, 2020
test: fix test-net-throttle
5ded044 
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: nodejs#33135

PR-URL: nodejs#33329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Trott force-pushed the fix-test-net-throttle branch from d348f0c to 5ded044 Compare May 11, 2020 18:42

Trott commented May 11, 2020

Copy link
Copy Markdown
Member Author

Landed in 5ded044

Trott merged commit 5ded044 into nodejs:master May 11, 2020
codebytere pushed a commit that referenced this pull request May 15, 2020
test: fix test-net-throttle
5b2cd44 
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: #33135

PR-URL: #33329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
test: fix test-net-throttle
c459832 
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: #33135

PR-URL: #33329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
codebytere mentioned this pull request Jun 9, 2020
Merged
Trott deleted the fix-test-net-throttle branch April 14, 2022 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flaky test-net-throttle on daily master

4 participants

Back | FazBrowse Home | New Git URL