FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: Delete unused variables to resolve compile time print warning by rickyes · Pull Request #33358 · nodejs/node · GitHub

/ node Public

src: Delete unused variables to resolve compile time print warning - #33358

Closed
rickyes wants to merge 1 commit into
nodejs:masterfrom
rickyes:remove-unused-variables
Closed

src: Delete unused variables to resolve compile time print warning#33358
rickyes wants to merge 1 commit into
nodejs:masterfrom
rickyes:remove-unused-variables

Conversation

rickyes commented May 11, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 11, 2020
richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 11, 2020

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

CI is yellow, 👍 to fast-track?

addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label May 12, 2020
richardlau pushed a commit that referenced this pull request May 12, 2020
PR-URL: #33358
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

Copy link
Copy Markdown
Member

Landed in aee36a0.

richardlau closed this May 12, 2020
rickyes deleted the remove-unused-variables branch May 12, 2020 14:26
codebytere pushed a commit that referenced this pull request May 16, 2020
PR-URL: #33358
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere mentioned this pull request May 18, 2020
codebytere pushed a commit that referenced this pull request Jun 7, 2020
PR-URL: #33358
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere mentioned this pull request Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL