test: fix test-dns-idna2008 - #33367
Merged
Trott merged 1 commit intoMay 15, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Internet tests aren't run in our regular CI so here's a CI for internet tests run the same way we run them in node-daily-master: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14228/ ✅ |
Sorry, something went wrong.
bnoordhuis
approved these changes
May 12, 2020
Copy link
Copy Markdown
Member
Author
|
@nodejs/dns @nodejs/testing (Hide whitespace in the diff because a lot of lines were moved to accommodate 80-char wrapping: https://github.com/nodejs/node/pull/33367/files?diff=unified&w=1) |
Sorry, something went wrong.
lpinca
approved these changes
May 15, 2020
The DNS server will sometimes return an IPv6 address (as seen in nightly CI from time to time). Use `family` option to force IPv4. PR-URL: nodejs#33367 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
May 16, 2020
The DNS server will sometimes return an IPv6 address (as seen in nightly CI from time to time). Use `family` option to force IPv4. PR-URL: #33367 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
The DNS server will sometimes return an IPv6 address (as seen in nightly CI from time to time). Use `family` option to force IPv4. PR-URL: #33367 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere
pushed a commit
to codebytere/node
that referenced
this pull request
Jun 9, 2020
The DNS server will sometimes return an IPv6 address (as seen in nightly CI from time to time). Use `family` option to force IPv4. PR-URL: nodejs#33367 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use family option to force IPv4.
Hide white-space changes in the diff to ignore all the code moved to accommodate line-wrapping at 80 chars.
This failed in node-daily-master last night. I'd like to fast-track. Please 👍 here if you are a Collaborator and agree this could/should be fast-tracked.
00:03:31 not ok 11 internet/test-dns-idna2008 00:03:31 --- 00:03:31 duration_ms: 1.15 00:03:31 severity: fail 00:03:31 exitcode: 1 00:03:31 stack: |- 00:03:31 assert.js:103 00:03:31 throw new AssertionError(obj); 00:03:31 ^ 00:03:31 00:03:31 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: 00:03:31 + actual - expected 00:03:31 00:03:31 + '2a01:238:20a:202:1078::' 00:03:31 - '81.169.145.78' 00:03:31 at GetAddrInfoReqWrap.<anonymous> (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/internet/test-dns-idna2008.js:32:10) 00:03:31 at GetAddrInfoReqWrap.callback (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/common/index.js:364:15) 00:03:31 at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:68:8) { 00:03:31 generatedMessage: true, 00:03:31 code: 'ERR_ASSERTION', 00:03:31 actual: '2a01:238:20a:202:1078::', 00:03:31 expected: '81.169.145.78', 00:03:31 operator: 'strictEqual' 00:03:31 } 00:03:31 ...Checklist