FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove deprecated FinalizationRegistry hooks by devsnek · Pull Request #33373 · nodejs/node · GitHub

/ node Public

src: remove deprecated FinalizationRegistry hooks - #33373

Merged
devsnek merged 1 commit into
nodejs:masterfrom
devsnek:nofg
May 14, 2020
ConversationCommits (1)ChecksFiles changed
Merged

src: remove deprecated FinalizationRegistry hooks#33373
devsnek merged 1 commit into
nodejs:masterfrom
devsnek:nofg

Conversation

devsnek commented May 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #33389

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

cc @syg

devsnek requested a review from addaleax May 12, 2020 18:27
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels May 12, 2020

nodejs-github-bot commented May 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31297/

targos mentioned this pull request May 13, 2020
Closed
targos mentioned this pull request May 13, 2020
Closed
devsnek mentioned this pull request May 13, 2020
Closed

targos commented May 13, 2020

Copy link
Copy Markdown
Member

fast-track to fix #33389?

targos added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels May 13, 2020

nodejs-github-bot commented May 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31310/

src: remove deprecated FinalizationRegistry hooks
eaa16cd 
PR-URL: nodejs#33373
Fixes: nodejs#33389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
devsnek merged commit eaa16cd into nodejs:master May 14, 2020

devsnek commented May 14, 2020

Copy link
Copy Markdown
Member Author

Landed in eaa16cd

devsnek deleted the nofg branch May 14, 2020 20:10
codebytere pushed a commit that referenced this pull request May 16, 2020
src: remove deprecated FinalizationRegistry hooks
0257386 
PR-URL: #33373
Fixes: #33389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere mentioned this pull request May 18, 2020
Merged
targos removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
richardlau richardlau approved these changes
+2 more reviewers
danbev danbev approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New build warnings

7 participants

Back | FazBrowse Home | New Git URL