test: fix flaky test-trace-atomics-wait - #33428
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This adds a possible ordering of the trace events that was missing from the list previously. Fixes: nodejs#33427
targos
approved these changes
May 16, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
approved these changes
May 16, 2020
cjihrig
approved these changes
May 16, 2020
jasnell
approved these changes
May 17, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 23, 2020
This adds a possible ordering of the trace events that was missing from the list previously. Fixes: nodejs#33427 PR-URL: nodejs#33428 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This adds a possible ordering of the trace events that was missing from the list previously. Fixes: #33427 PR-URL: #33428 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This adds a possible ordering of the trace events that was missing from the list previously. Fixes: #33427 PR-URL: #33428 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
This adds a possible ordering of the trace events that was missing from the list previously. Fixes: #33427 PR-URL: #33428 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a possible ordering of the trace events that was missing
from the list previously.
Fixes: #33427
(This doesn’t fully fix flakiness for me, but it reduces the number of failures from the 10 % observed in #33427 to 0.1 %, and that remainder comes from segfaults that I’m still looking into – but in any case, a real bug as opposed to something that makes this particular test flaky. Edit: #33429)
Checklist