deps: update node-inspect to v2.0.0 - #33447
Closed
hybrist wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Highlights: * Remove use of `process.binding` on modern node (@addaleax) * Increase timeout for port checking (@yilmazdurmaz) * Auto-resume on start when `NODE_INSPECT_RESUME_ON_START` is set (@dolsem) Compare: nodejs/node-inspect@v1.11.6...v2.0.0
hybrist
marked this pull request as ready for review
May 17, 2020 18:31
Copy link
Copy Markdown
Member
|
Rubber-stamp LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
May 19, 2020
mmarchini
approved these changes
May 20, 2020
mmarchini
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
bnoordhuis
approved these changes
May 20, 2020
addaleax
pushed a commit
that referenced
this pull request
May 20, 2020
Highlights: * Remove use of `process.binding` on modern node (@addaleax) * Increase timeout for port checking (@yilmazdurmaz) * Auto-resume on start when `NODE_INSPECT_RESUME_ON_START` is set (@dolsem) Compare: nodejs/node-inspect@v1.11.6...v2.0.0 PR-URL: #33447 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Highlights: * Remove use of `process.binding` on modern node (@addaleax) * Increase timeout for port checking (@yilmazdurmaz) * Auto-resume on start when `NODE_INSPECT_RESUME_ON_START` is set (@dolsem) Compare: nodejs/node-inspect@v1.11.6...v2.0.0 PR-URL: #33447 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 6, 2020
Highlights: * Remove use of `process.binding` on modern node (@addaleax) * Increase timeout for port checking (@yilmazdurmaz) * Auto-resume on start when `NODE_INSPECT_RESUME_ON_START` is set (@dolsem) Compare: nodejs/node-inspect@v1.11.6...v2.0.0 PR-URL: #33447 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
codebytere
added a commit
that referenced
this pull request
Jul 13, 2020
codebytere
added a commit
that referenced
this pull request
Jul 14, 2020
codebytere
added a commit
that referenced
this pull request
Jul 21, 2020
codebytere
added a commit
that referenced
this pull request
Jul 21, 2020
codebytere
added a commit
that referenced
this pull request
Jul 22, 2020
codebytere
added a commit
that referenced
this pull request
Jul 22, 2020
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights:
Compare: nodejs/node-inspect@v1.11.6...v2.0.0
Generated via:
The version number increase is somewhat arbitrary this time around. It's a CLI so "major version" is ill defined. Main reason for picking 2.0.0 was that the tool is no longer tested on node <12.
Checklist