FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: add flaky test issue template by AshCripps · Pull Request #33500 · nodejs/node · GitHub

/ node Public

meta: add flaky test issue template - #33500

Closed
AshCripps wants to merge 1 commit into
nodejs:masterfrom
AshCripps:add-flaky-test-template
ConversationCommits (1)ChecksFiles changed
Closed

meta: add flaky test issue template#33500
AshCripps wants to merge 1 commit into
nodejs:masterfrom
AshCripps:add-flaky-test-template

Conversation

AshCripps commented May 21, 2020

Copy link
Copy Markdown
Member

Add a flaky test issue template to ensure that enough information is provided for investigation

I think this will be useful especially for newer people interested in helping out the build WG as it requires no access to report flaky tests, and is often an approach we ask people to take to help familarise themselves with our CI/test suite.

Checklist

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 21, 2020

bcoe commented May 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@AshCripps this is topical. I'm working with a group of interns this summer on a project related to accurately and automatically detecting flaky tests in a codebase (CC: @joyeecheung).

Would love to see if we could use Node.js as a place to test the methods we're coming up with.

I think developing a template for this is a great idea.

bcoe reviewed May 21, 2020
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/4-report-a-flaky-test.md Outdated
Comment thread .github/ISSUE_TEMPLATE/4-report-a-flaky-test.md Outdated
sam-github reviewed May 21, 2020
View reviewed changes

sam-github left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some suggested text tweeks. I would find this template useful to bring some more structure to the flaky test reports.

Comment thread .github/ISSUE_TEMPLATE/4-report-a-flaky-test.md Outdated
Comment thread .github/ISSUE_TEMPLATE/4-report-a-flaky-test.md Outdated
AshCripps force-pushed the add-flaky-test-template branch from 37aef5f to a42ab32 Compare May 22, 2020 11:09

AshCripps commented May 22, 2020

Copy link
Copy Markdown
Member Author

@bcoe @sam-github Ive addressed your comments, I've tried the details block, it didn't look too great locally but need to see how it looks on GitHub.

sam-github commented May 22, 2020

Copy link
Copy Markdown
Contributor

@bcoe WDYT? I'd be tempted to leave it out, the tap output is usually not that long.

BridgeAR reviewed May 23, 2020
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/4-report-a-flaky-test.md Outdated
Comment thread .github/ISSUE_TEMPLATE/4-report-a-flaky-test.md Outdated
meta: add flaky test issue template
78f1402 
Add a flaky test issue template to ensure that enough information is provided for investigation
AshCripps force-pushed the add-flaky-test-template branch from a42ab32 to 78f1402 Compare May 26, 2020 10:41

AshCripps commented May 26, 2020

Copy link
Copy Markdown
Member Author

I updated this to remove the details block as it didn't look right IMO and have instead put a REPLACE ME inside a code block so the output will be formatted properly

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 26, 2020
sam-github pushed a commit that referenced this pull request May 28, 2020
meta: add flaky test issue template
fb33b67 
Add a flaky test issue template to ensure that enough information is
provided for investigation

PR-URL: #33500
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

sam-github commented May 28, 2020

Copy link
Copy Markdown
Contributor

Landed in fb33b67

sam-github closed this May 28, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
meta: add flaky test issue template
2aa6469 
Add a flaky test issue template to ensure that enough information is
provided for investigation

PR-URL: #33500
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
AshCripps deleted the add-flaky-test-template branch June 25, 2020 14:01
codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
meta: add flaky test issue template
3b9e9b6 
Add a flaky test issue template to ensure that enough information is
provided for investigation

PR-URL: #33500
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
meta: add flaky test issue template
b7ea7be 
Add a flaky test issue template to ensure that enough information is
provided for investigation

PR-URL: #33500
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere mentioned this pull request Jul 13, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BethGriggs BethGriggs approved these changes
BridgeAR BridgeAR approved these changes
+2 more reviewers
sam-github sam-github left review comments
bcoe bcoe left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL