FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

events: fix event-target enumerable keys by benjamingr · Pull Request #33616 · nodejs/node · GitHub

/ node Public

events: fix event-target enumerable keys - #33616

Closed
benjamingr wants to merge 1 commit into
nodejs:masterfrom
benjamingr:event-target-enumerable-keys
ConversationCommits (1)ChecksFiles changed
Closed

events: fix event-target enumerable keys#33616
benjamingr wants to merge 1 commit into
nodejs:masterfrom
benjamingr:event-target-enumerable-keys

Conversation

benjamingr commented May 28, 2020

Copy link
Copy Markdown
Member

Another quick one as I look for deltas before adding the WPTs.

TIL about https://heycam.github.io/webidl/#LegacyUnforgeable

Also I asked about this behavior on #whatwg to make sure I got it right (Edge behaves differently from Chrome and Firefox here)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

benjamingr added the events Issues and PRs related to the events subsystem / EventEmitter. label May 28, 2020
benjamingr requested a review from jasnell May 28, 2020 15:10

benjamingr commented May 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Verified with Anne that this is the correct behavior - here is the relevant reference https://heycam.github.io/webidl/#define-the-unforgeable-regular-attributes

jasnell reviewed May 28, 2020
View reviewed changes
Comment thread test/parallel/test-eventtarget.js

{
const ev = new Event('foo');
deepStrictEqual(Object.keys(ev), ['isTrusted']);

jasnell May 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should this include a test that the value cannot be changed? I assume that's likely covered in the WPT tho?

benjamingr May 28, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Indeed it is https://github.com/web-platform-tests/wpt/blob/master/dom/events/Event-isTrusted.any.js :]

nodejs-github-bot commented May 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31612/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 28, 2020

nodejs-github-bot commented May 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31616/

jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label May 29, 2020

jasnell commented May 29, 2020

Copy link
Copy Markdown
Member

Experimental fixups to an unreleased feature... 👍 to fast track

BridgeAR commented May 30, 2020

Copy link
Copy Markdown
Member

Landed in 2d071e7

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 30, 2020
events: fix event-target enumerable keys
2d071e7 
PR-URL: nodejs#33616
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR closed this May 30, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
events: fix event-target enumerable keys
2a29ced 
PR-URL: #33616
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
events: fix event-target enumerable keys
4b7ffa5 
PR-URL: #33616
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax mentioned this pull request Sep 22, 2020
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL