doc: update wasi code sample - #33626
Conversation
Sorry, something went wrong.
addaleax
left a comment
There was a problem hiding this comment.
LGTM with the linter failures addressed
Sorry, something went wrong.
|
Just note. you actually don’t need wabt or wat2wasm tools. You may use webassembly extension for vscode to compile wat to wasm. |
Sorry, something went wrong.
@reklatsmasters VSCode webassembly extension uses wabt as a dependency (see package.json), which is a JS port of wabt. Moreover, I don't think VSCode extension is a standard way of compiling wat to wasm, but can be an option to consider for VSCode users. |
Sorry, something went wrong.
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console Note: This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Actually, I had to back this out of master because this conflicts with the linter rules introduced by 0ef6956 … @Trott or @DerekNonGeneric Could you push a fixup commit to this PR and then land this? I’m not sure what the linter expects here myself. |
Sorry, something went wrong.
I'll make a judgment call and push a fixup commit (and then land, and then open a PR to get the lint presets updated if appropriate). |
Sorry, something went wrong.
|
Fixed-up and force-pushed. |
Sorry, something went wrong.
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI is green
Sorry, something went wrong.
|
All the linters came back green. Landing. |
Sorry, something went wrong.
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
wasi: update code sample
Code sample updated by adding a hello-world (demo.wat) code example. Step for compiling .wat to .wasm added (with reference to wabt tools). The sample code prints "hello world\n" in the console. Note: This update can be treated as an extension to the existing sample.
Checklist