FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: add RFC references for each status code by Voltra · Pull Request #33671 · nodejs/node · GitHub

/ node Public

http: add RFC references for each status code - #33671

Closed
Voltra wants to merge 2 commits into
nodejs:masterfrom
Voltra:master
ConversationCommits (2)ChecksFiles changed
Closed

http: add RFC references for each status code#33671
Voltra wants to merge 2 commits into
nodejs:masterfrom
Voltra:master

Conversation

Voltra commented May 31, 2020

Copy link
Copy Markdown
Contributor

Reference format is as follows RFC <rfc id> <section path>. Using the RFC reference makes it easier to get more information regarding the status code directly from IETF.

Checklist

lib: add RFC references for each status code
906464e 
Reference format: `RFC <rfc id> <section path>`
nodejs-github-bot added the http Issues or PRs related to the http subsystem. label May 31, 2020
http: add RFC references for each status code
da92127 
Reference format is as follows RFC <rfc id> <section path>. Using the RFC reference makes it easier to get more information regarding the status code directly from IETF.
benjamingr approved these changes May 31, 2020
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for this 🙇

Ethan-Arrowood commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

Is there any interest in duplicating this list in the HTTP docs as well? We could also link to MDN docs for these codes which is one of my go to resources for it

Voltra commented Jun 2, 2020

Copy link
Copy Markdown
Contributor Author

Is there any interest in duplicating this list in the HTTP docs as well? We could also link to MDN docs for these codes which is one of my go to resources for it

If there is such interest, I would be more than happy to work on it (maybe as a follow up pull request). I'm thinking about referencing, under a new section, all status code using the following format: <code> <label> <MDN link> <IETF link> (with exceptions for codes such as 509).

Ethan-Arrowood commented Jun 2, 2020

Copy link
Copy Markdown
Contributor

+1 for a separate PR - feel free to tag me I'll help review 😄

rexagod approved these changes Jun 8, 2020
View reviewed changes

rexagod left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks amazing! Thank you!

rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2020

nodejs-github-bot commented Aug 10, 2020 •
edited by rickyes
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32705/ ✅

Voltra requested a review from a team as a code owner August 10, 2020 16:07
rickyes added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 15, 2020
rickyes pushed a commit that referenced this pull request Aug 15, 2020
http: add RFC references for each status code
9594b54 
Reference format: `RFC <rfc id> <section path>`

PR-URL: #33671
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

rickyes commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

Landed in 9594b54
@Voltra congratulations on your first commit to Node.js! 🎉

rickyes closed this Aug 15, 2020
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
http: add RFC references for each status code
c3a1dd5 
Reference format: `RFC <rfc id> <section path>`

PR-URL: #33671
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
http: add RFC references for each status code
952f233 
Reference format: `RFC <rfc id> <section path>`

PR-URL: #33671
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
+2 more reviewers
rickyes rickyes approved these changes
rexagod rexagod approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL