build: add LINT_CPP_FILES to checkimports check - #33697
Closed
danbev wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked.
This commit removes the reported unused using declarations from cache_builder.cc
richardlau
approved these changes
Jun 2, 2020
targos
approved these changes
Jun 2, 2020
cjihrig
approved these changes
Jun 2, 2020
jasnell
approved these changes
Jun 2, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jun 6, 2020
Copy link
Copy Markdown
Contributor
Author
|
Re-run of failing node-test-commit-osx ✔️ |
Sorry, something went wrong.
danbev
added a commit
that referenced
this pull request
Jun 8, 2020
This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. PR-URL: #33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danbev
added a commit
that referenced
this pull request
Jun 8, 2020
This commit removes the reported unused using declarations from cache_builder.cc PR-URL: #33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
This was referenced Jun 9, 2020
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. PR-URL: #33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This commit removes the reported unused using declarations from cache_builder.cc PR-URL: #33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. PR-URL: #33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
This commit removes the reported unused using declarations from cache_builder.cc PR-URL: #33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. PR-URL: #33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
This commit removes the reported unused using declarations from cache_builder.cc PR-URL: #33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. PR-URL: #33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
This commit removes the reported unused using declarations from cache_builder.cc PR-URL: #33697 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the prerequisites which contains all the files to lint.
Currently the only the files in 'src' will be checked.
Checklist