Test: Changed function to arrow function - #33711
Closed
sagar-jadhav wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cjihrig
approved these changes
Jun 3, 2020
gireeshpunathil
approved these changes
Jun 3, 2020
jasnell
approved these changes
Jun 3, 2020
juanarbol
reviewed
Jun 5, 2020
Comment thread
test/parallel/test-util-promisify.js
Outdated
juanarbol
approved these changes
Jun 5, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Convert callback functions that are anonymous to arrow functions for better readability.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
himself65
approved these changes
Jun 6, 2020
juanarbol
pushed a commit
that referenced
this pull request
Jun 6, 2020
Convert callback functions that are anonymous to arrow functions for better readability. PR-URL: #33711 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Copy link
Copy Markdown
Contributor
Author
|
Thank you 👍 |
Sorry, something went wrong.
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Convert callback functions that are anonymous to arrow functions for better readability. PR-URL: #33711 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Convert callback functions that are anonymous to arrow functions for better readability. PR-URL: #33711 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 9, 2020
Convert callback functions that are anonymous to arrow functions for better readability. PR-URL: #33711 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
Convert callback functions that are anonymous to arrow functions for better readability. PR-URL: #33711 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted anonymous callback functions to arrow functions for better readability.
Checklist
Note: Some unrelated tests failed with timeout error on macOS