FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix FastStringKey equal operator by sapics · Pull Request #33748 · nodejs/node · GitHub

/ node Public

src: fix FastStringKey equal operator - #33748

Closed
sapics wants to merge 1 commit into
nodejs:masterfrom
sapics:fix-faststringkey-operator
Closed

src: fix FastStringKey equal operator#33748
sapics wants to merge 1 commit into
nodejs:masterfrom
sapics:fix-faststringkey-operator

Conversation

sapics commented Jun 5, 2020

Copy link
Copy Markdown
Contributor
  1. This PR fixes the FastStringKey == operator. (Currently, there are some cases which return true, when the length of string is not same).
  2. Currently, FastStringKey::HashImpl return multiple of 33, thus it would be better to move while to first.
Checklist

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 5, 2020
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 12, 2020

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

jasnell pushed a commit that referenced this pull request Jun 24, 2020
PR-URL: #33748
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

jasnell commented Jun 24, 2020

Copy link
Copy Markdown
Member

Landed in 5a0c66

jasnell closed this Jun 24, 2020
sapics deleted the fix-faststringkey-operator branch June 24, 2020 23:35
codebytere pushed a commit that referenced this pull request Jun 27, 2020
PR-URL: #33748
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33748
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Copy link
Copy Markdown
Member

Backport blocked on #33139

sapics commented Jul 11, 2020

Copy link
Copy Markdown
Contributor Author

Thank you for trying backport!
This PR fixes the bug of the functionality which created in #33139.
Thus, if #33139 is not backported, it is okay if we cannot backport this PR.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL