FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

events:use property, primordials by benjamingr · Pull Request #33775 · nodejs/node · GitHub

/ node Public

events:use property, primordials - #33775

Closed
benjamingr wants to merge 2 commits into
nodejs:masterfrom
benjamingr:event-target-string-tag-symbol
ConversationCommits (2)ChecksFiles changed
Closed

events:use property, primordials#33775
benjamingr wants to merge 2 commits into
nodejs:masterfrom
benjamingr:event-target-string-tag-symbol

Conversation

benjamingr commented Jun 6, 2020

Copy link
Copy Markdown
Member

Per Web IDL, EventTarget.prototype[Symbol.toStringTag] should be a data property, not a getter. Commit 56e4460 introduced it as a getter.

This commit uses SymbolToStringTag from primordials and sets it as a property and not a getter.

Thank you Domenic for pointing this out!

Fixes: #33773
cc @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

benjamingr requested a review from jasnell June 6, 2020 18:47
benjamingr added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 7, 2020

nodejs-github-bot commented Jun 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31913/

jasnell pushed a commit that referenced this pull request Jun 18, 2020
events: use property, primordials
ea866dc 
PR-URL: #33775
Fixes: #33773
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Jun 18, 2020

Copy link
Copy Markdown
Member

Landed in ea866dc

jasnell closed this Jun 18, 2020
codebytere pushed a commit that referenced this pull request Jun 22, 2020
events: use property, primordials
eb01214 
PR-URL: #33775
Fixes: #33773
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
events: use property, primordials
17edf65 
PR-URL: #33775
Fixes: #33773
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax mentioned this pull request Sep 22, 2020
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
himself65 himself65 approved these changes
+1 more reviewer
lundibundi lundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Minor EventTarget correctness issues

6 participants

Back | FazBrowse Home | New Git URL