n-api: document nextTick timing in callbacks - #33804
Closed
mafintosh wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mcollina
reviewed
Jun 9, 2020
Comment thread
doc/api/n-api.md
Outdated
mafintosh
force-pushed
the
n-api-next-tick-timing
branch
from
91b6970 to
f457dd0
Compare
June 9, 2020 09:20
mcollina
approved these changes
Jun 9, 2020
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
mafintosh
force-pushed
the
n-api-next-tick-timing
branch
from
f457dd0 to
96d65ba
Compare
June 9, 2020 09:25
legendecas
approved these changes
Jun 9, 2020
legendecas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
👍 Overall LGTM. Please address the issue that lint complains.
Sorry, something went wrong.
jasnell
approved these changes
Jun 9, 2020
addaleax
approved these changes
Jun 9, 2020
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with the linter warning addressed – and the linter complaint is correct, this isn’t a side effect of the function but rather half its purpose :)
Sorry, something went wrong.
mafintosh
force-pushed
the
n-api-next-tick-timing
branch
from
96d65ba to
e848bb4
Compare
June 11, 2020 11:49
Copy link
Copy Markdown
Member
Author
|
Updated the message |
Sorry, something went wrong.
legendecas
approved these changes
Jun 11, 2020
Comment thread
doc/api/n-api.md
| `napi_create_async_work`. | ||
|
|
||
| Any `process.nextTick`s or Promises scheduled on the microtask queue by | ||
| JavaScript during the callback are ran before returning back to C/C++. |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| JavaScript during the callback are ran before returning back to C/C++. | |
| JavaScript during the callback are run before returning back to C/C++. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Better perhaps?
Suggested change
| JavaScript during the callback are ran before returning back to C/C++. | |
| JavaScript during the callback are executed before returning back to C/C++. |
Sorry, something went wrong.
gabrielschulhof
approved these changes
Jun 15, 2020
mhdawson
approved these changes
Jun 16, 2020
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with fixes suggested by @gabrielschulhof
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
pushed a commit
that referenced
this pull request
Jun 17, 2020
PR-URL: #33804 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33804 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33804 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
PR-URL: #33804 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #33804 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Document that nextTicks when c/c++ calls js are ran before returning to c/c++ if any are scheduled by the js callback. Just fixed a bug in Electron related to this, so thought we could help others avoid this quirk by making it more clear.