FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: temporarily exclude test on arm by mhdawson · Pull Request #33814 · nodejs/node · GitHub

/ node Public

test: temporarily exclude test on arm - #33814

Closed
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:excltest2
ConversationCommits (2)ChecksFiles changed
Closed

test: temporarily exclude test on arm#33814
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:excltest2

Conversation

mhdawson commented Jun 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Temporarily excluded until #33796 is resolved.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

test: temporarily exclude test on arm
e435084 
Refs: nodejs#33796

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 9, 2020

mhdawson commented Jun 9, 2020

Copy link
Copy Markdown
Member Author

CI run: https://ci.nodejs.org/job/node-test-pull-request/31802/

mhdawson closed this Jun 9, 2020
addaleax approved these changes Jun 9, 2020
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This test is not inherently broken on the platform – it should pass on ARM. Let’s mark it flaky instead of just not running it.

Comment thread test/parallel/parallel.status Outdated

mhdawson commented Jun 9, 2020

Copy link
Copy Markdown
Member Author

Would like to ask that this is fast-tracked if it gets CI to green.

addaleax reopened this Jun 9, 2020
mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 9, 2020
Update test/parallel/parallel.status
56c95c4 
Co-authored-by: Anna Henningsen <github@addaleax.net>

nodejs-github-bot commented Jun 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31803/

mhdawson commented Jun 9, 2020

Copy link
Copy Markdown
Member Author

Updated CI run: https://ci.nodejs.org/job/node-test-pull-request/31803/

mhdawson commented Jun 9, 2020

Copy link
Copy Markdown
Member Author

CI run was green landing.

mhdawson added a commit that referenced this pull request Jun 9, 2020
test: temporarily exclude test on arm
502f53f 
Refs: #33796

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

mhdawson commented Jun 9, 2020

Copy link
Copy Markdown
Member Author

Landed in 502f53f

mhdawson closed this Jun 9, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
test: temporarily exclude test on arm
e3a5332 
Refs: #33796

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
test: temporarily exclude test on arm
4bb0670 
Refs: #33796

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
test: temporarily exclude test on arm
b5113d0 
Refs: #33796

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
test: temporarily exclude test on arm
ce0ab70 
Refs: #33796

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
mhdawson deleted the excltest2 branch September 14, 2020 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL