FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: handle missing TracingController everywhere by addaleax · Pull Request #33815 · nodejs/node · GitHub

/ node Public

src: handle missing TracingController everywhere - #33815

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:tracing-controller-nullptr
ConversationCommits (1)ChecksFiles changed
Closed

src: handle missing TracingController everywhere#33815
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:tracing-controller-nullptr

Conversation

addaleax commented Jun 9, 2020

Copy link
Copy Markdown
Member

Fixes: #33800

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 9, 2020
addaleax mentioned this pull request Jun 9, 2020
Closed
addaleax added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. embedding Issues and PRs related to embedding Node.js in another project. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Jun 10, 2020

nodejs-github-bot commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31811/

gireeshpunathil reviewed Jun 10, 2020
View reviewed changes
Comment thread src/tracing/trace_event.h
Comment on lines 475 to +477
v8::TracingController* controller =
node::tracing::TraceEventHelper::GetTracingController();
if (controller == nullptr) return 0;

gireeshpunathil Jun 10, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

may be move this to the beginning of the function? here and in AddMetadataEventImpl ?

addaleax Jun 10, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gireeshpunathil How would I do that without introducing a potential memory leak?

gireeshpunathil Jun 10, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@addaleax - I am sorry, but not following: we have a nullcheck and return (with no trace action) in the middle of a function, it can be moved to the start of the function, to save some cpu cycles in cases where the tracing controller is NULL?

addaleax Jun 10, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gireeshpunathil Yes, but the lines between the start of the function and here take ownership of memory, so moving this line would cause a memory leak?

gireeshpunathil Jun 10, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

do you mean the std::unique_ptr<v8::ConvertableToTraceFormat> objects? cant those be allocated only in the normal path? i.e., if TracingController object is not null?

addaleax Jun 10, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gireeshpunathil They are not being allocated here, though – this function only takes ownership of them.

nodejs-github-bot commented Jun 11, 2020 •
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31833/ (:yellow_heart:)

addaleax added a commit that referenced this pull request Jun 11, 2020
src: handle missing TracingController everywhere
dfdbbd1 
Fixes: #33800

PR-URL: #33815
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax commented Jun 11, 2020

Copy link
Copy Markdown
Member Author

Landed in dfdbbd1

addaleax closed this Jun 11, 2020
addaleax deleted the tracing-controller-nullptr branch June 11, 2020 19:53
addaleax added lts-watch-v12.x and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jun 11, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
src: handle missing TracingController everywhere
f8dddd3 
Fixes: #33800

PR-URL: #33815
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
src: handle missing TracingController everywhere
92983f2 
Fixes: #33800

PR-URL: #33815
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
src: handle missing TracingController everywhere
86283aa 
Fixes: #33800

PR-URL: #33815
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
src: handle missing TracingController everywhere
1255e37 
Fixes: #33800

PR-URL: #33815
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gireeshpunathil gireeshpunathil left review comments
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. embedding Issues and PRs related to embedding Node.js in another project. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segfault Creating Node Environments in v12.16.2

6 participants

Back | FazBrowse Home | New Git URL