FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

account for CLANG_VENDOR when checking for llvm version by nathanblair · Pull Request #33860 · nodejs/node · GitHub

/ node Public

account for CLANG_VENDOR when checking for llvm version - #33860

Closed
nathanblair wants to merge 1 commit into
nodejs:masterfrom
nathanblair:clang-vendor-fix
ConversationCommits (1)ChecksFiles changed
Closed

account for CLANG_VENDOR when checking for llvm version#33860
nathanblair wants to merge 1 commit into
nodejs:masterfrom
nathanblair:clang-vendor-fix

Conversation

nathanblair commented Jun 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Checklist

Apologies if I'm forgetting something - this is my first commit to node. I didn't think it necessary to include testing results as no src code is actually modified; only the configure script.

Please see issue #29536 for more details. I have not verified if this breaks configurations on systems like void-linux where a CLANG_VENDOR` is not specified, but it did fix the issue on alpine linux. Before this PR is merged, I'd like to investigate that it can be built in such cases.

In the meantime, it would help to possibly get other members to verify the change allows clang/llvm to be recognized by their various systems.

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 13, 2020
sapics reviewed Jun 13, 2020
View reviewed changes
Comment thread configure.py
def get_llvm_version(cc):
return get_version_helper(
cc, r"(^(?:FreeBSD )?clang version|based on LLVM) ([0-9]+\.[0-9]+)")
cc, r"(^(?:.+ )?clang version|based on LLVM) ([0-9]+\.[0-9]+)")

sapics Jun 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For detecting the support of OpenSSL's functionality, configure.py checks xcode_version>=5.0 or llvm_version>=3.3 in https://github.com/nodejs/node/blob/master/configure.py#L1330
Thus, it changes the detection result for ex. Apple clang version 4.0.

If you need to check for Alpine, below one would be better.

- cc, r"(^(?:FreeBSD )?clang version|based on LLVM) ([0-9]+\.[0-9]+)")
+ cc, r"(^(?:(?:FreeBSD|Alpine) )?clang version|based on LLVM) ([0-9]+\.[0-9]+)")

nathanblair Jun 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That's what this PR is intended to fix. It won't be feasible to hard code the regex string for specific CLANG_VENDORs. Because what if I want to compile clang myself and I set my CLANG_VENDOR to "MyClang". Now I have to recompile Nodejs for whatever distribution I'm using - and I haven't even changed anything specifically related to Nodejs's functionality or behavior. The check here only cares about returning a version string - it doesn't care about the vendor; so there should be no need to do anything other than match against a Word.

I also compiled nodejs using this branch on my Macbook Pro and it worked just fine. 😄

sapics Jun 25, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for late response.
The problem I pointed out does not occur now, because Apple LLVM >= 10 is the supported version.

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 19, 2020

nodejs-github-bot commented Jun 19, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31959/

This was referenced Jun 20, 2020
Open
Open
Open
Open
Open

nodejs-github-bot commented Jun 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32055/

github-actions Bot mentioned this pull request Jun 25, 2020
Open
14 tasks
jasnell pushed a commit that referenced this pull request Jun 25, 2020
configure: account for CLANG_VENDOR when checking for llvm version
409fdba 
Fixes: #29536

PR-URL: #33860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Jun 25, 2020

Copy link
Copy Markdown
Member

Landed in 409fdba

jasnell closed this Jun 25, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
configure: account for CLANG_VENDOR when checking for llvm version
0a7f13e 
Fixes: #29536

PR-URL: #33860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
configure: account for CLANG_VENDOR when checking for llvm version
a4c63c7 
Fixes: #29536

PR-URL: #33860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
configure: account for CLANG_VENDOR when checking for llvm version
4d15025 
Fixes: #29536

PR-URL: #33860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
configure: account for CLANG_VENDOR when checking for llvm version
817f659 
Fixes: #29536

PR-URL: #33860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
configure: account for CLANG_VENDOR when checking for llvm version
7f70c5d 
Fixes: #29536

PR-URL: #33860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
+1 more reviewer
sapics sapics left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL