http: make http.OutgoingMessage inherit Stream.Writable - #33870
Closed
rexagod wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
After these changes, properties that are present:
[ '_destroy', '_undestroy', '_write', '_writev', 'setDefaultEncoding', 'writableBuffer' ]
[ '_finish', '_flush', '_flushOutput', '_headerNames', '_headers', '_implicitHeader', '_renderHeaders', '_send', '_storeHeader', '_writeRaw', 'addTrailers', 'connection', 'flushHeaders', 'getHeader', 'getHeaderNames', 'getHeaders', 'hasHeader', 'headersSent', 'removeHeader', 'setHeader', 'setTimeout' ]
[ 'constructor', 'cork', 'destroy', 'destroyed', 'end', 'pipe', 'uncork', 'writable', 'writableCorked', 'writableEnded', 'writableFinished', 'writableHighWaterMark', 'writableLength', 'writableObjectMode', 'write' ] |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
ronag
requested changes
Jun 14, 2020
Copy link
Copy Markdown
Member
|
Have you benchmarked this change? Last time I tried this it slowed things down and it was not really feasible. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I see. I tried benchmarking this for create-clientrequest.js and results show a negative improvement on performance. #33515 looks interesting, and I reckon it will allow us to successfully inherit and avoid performance degradation once it's done. confidence improvement accuracy (*) (**) (***) http/create-clientrequest.js e=1 arg='options' url='idn' -1.99 % ±5.13% ±6.84% ±8.92% http/create-clientrequest.js e=1 arg='options' url='long' -2.35 % ±3.10% ±4.13% ±5.38% http/create-clientrequest.js e=1 arg='options' url='wpt' -2.48 % ±5.00% ±6.65% ±8.67% http/create-clientrequest.js e=1 arg='string' url='idn' -1.64 % ±2.22% ±2.97% ±3.89% http/create-clientrequest.js e=1 arg='string' url='long' -1.15 % ±1.47% ±1.96% ±2.56% http/create-clientrequest.js e=1 arg='string' url='wpt' -0.34 % ±2.20% ±2.93% ±3.82% http/create-clientrequest.js e=1 arg='URL' url='idn' -1.03 % ±2.03% ±2.70% ±3.52% http/create-clientrequest.js e=1 arg='URL' url='long' ** -6.56 % ±4.28% ±5.75% ±7.60% http/create-clientrequest.js e=1 arg='URL' url='wpt' 1.99 % ±3.57% ±4.77% ±6.27% In the meantime, I'll find some more issues to dig in. Feel free to close this one. :) |
Sorry, something went wrong.
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This was referenced Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #28971
Checklist