doc: clarifying thread safe function references - #33871
Closed
legendecas wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
legendecas
force-pushed
the
doc-tsfn
branch
3 times, most recently
from
6bef69d to
06bbe1c
Compare
June 14, 2020 07:57
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
addaleax
approved these changes
Jun 19, 2020
jasnell
approved these changes
Jun 19, 2020
rexagod
reviewed
Jun 20, 2020
Comment thread
doc/api/n-api.md
Outdated
gabrielschulhof
approved these changes
Jun 23, 2020
gabrielschulhof
pushed a commit
that referenced
this pull request
Jun 23, 2020
PR-URL: #33871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
PR-URL: #33871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
PR-URL: #33871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 12, 2020
PR-URL: #33871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #33871 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #25341
Clarifying that neither napi_ref_threadsafe_function nor napi_unref_threadsafe_function marks the thread-safe functions to be able to be destroyed or prevent them from been destroyed.
initial_thread_count acts as same as calling napi_acquire_threadsafe_function multiple times.
Also, adding small titles in the chapter "Asynchronous Thread-safe Function Calls" to make it easier to read such a large section.
Checklist