FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: simplify alignment-handling code by addaleax · Pull Request #33884 · nodejs/node · GitHub

/ node Public

src: simplify alignment-handling code - #33884

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:alignup
Closed

src: simplify alignment-handling code#33884
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:alignup

Conversation

Copy link
Copy Markdown
Member

Use a common function to handle alignment computations in
multiple places.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Use a common function to handle alignment computations in
multiple places.
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 14, 2020

Copy link
Copy Markdown
Collaborator

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 19, 2020

Copy link
Copy Markdown
Collaborator

addaleax added a commit that referenced this pull request Jun 19, 2020
Use a common function to handle alignment computations in
multiple places.

PR-URL: #33884
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Copy link
Copy Markdown
Member Author

Landed in 2899588

addaleax closed this Jun 19, 2020
addaleax deleted the alignup branch June 19, 2020 15:34
codebytere pushed a commit that referenced this pull request Jun 27, 2020
Use a common function to handle alignment computations in
multiple places.

PR-URL: #33884
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Use a common function to handle alignment computations in
multiple places.

PR-URL: #33884
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL