FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

typo and style fix by gengjiawen · Pull Request #33976 · nodejs/node · GitHub

/ node Public

typo and style fix - #33976

Closed
gengjiawen wants to merge 3 commits into
nodejs:masterfrom
gengjiawen:misc_fix
ConversationCommits (3)ChecksFiles changed
Closed

typo and style fix#33976
gengjiawen wants to merge 3 commits into
nodejs:masterfrom
gengjiawen:misc_fix

Conversation

gengjiawen commented Jun 19, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. labels Jun 19, 2020
jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Jun 19, 2020

nodejs-github-bot commented Jun 22, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32012/

gengjiawen added a commit that referenced this pull request Jun 22, 2020
src: improve indention for upd_wrap.cc
25413b0 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gengjiawen added a commit that referenced this pull request Jun 22, 2020
test: fix typo in common/index.js
74cd70e 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gengjiawen added a commit that referenced this pull request Jun 22, 2020
test: fix typo in test-quic-client-empty-preferred-address.js
326a79e 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

gengjiawen commented Jun 22, 2020

Copy link
Copy Markdown
Member Author

Landed in 09330fc...326a79e

gengjiawen closed this Jun 22, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
src: improve indention for upd_wrap.cc
cd0ae40 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 27, 2020
test: fix typo in common/index.js
90223f0 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
src: improve indention for upd_wrap.cc
7381853 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
test: fix typo in common/index.js
fa8636c 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
src: improve indention for upd_wrap.cc
cd5af16 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
test: fix typo in common/index.js
9521c70 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
src: improve indention for upd_wrap.cc
6d5383d 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
test: fix typo in common/index.js
b9f8034 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
src: improve indention for upd_wrap.cc
37692b5 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 14, 2020
test: fix typo in common/index.js
eb4b1d6 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
trivikr trivikr approved these changes
+2 more reviewers
devnexen devnexen approved these changes
MrHeer MrHeer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL