doc: piping from async generators using pipeline() - #33992
Closed
WilliamConnatser wants to merge 1 commit into
Closed
doc: piping from async generators using pipeline()#33992WilliamConnatser wants to merge 1 commit into
WilliamConnatser wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
WilliamConnatser
force-pushed
the
master
branch
2 times, most recently
from
43d87e5 to
d67ecbf
Compare
June 20, 2020 18:44
addaleax
approved these changes
Jun 20, 2020
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@nodejs/streams
Sorry, something went wrong.
lpinca
approved these changes
Jun 20, 2020
ronag
reviewed
Jun 20, 2020
Comment thread
doc/api/stream.md
Outdated
Trott
reviewed
Jun 20, 2020
Comment thread
doc/api/stream.md
Outdated
Trott
reviewed
Jun 20, 2020
Comment thread
doc/api/stream.md
Outdated
Copy link
Copy Markdown
Member
|
I think we might want to iterate on that a bit more, so if this is ready we should land. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank ya'll for your feedback. I have implemented all edits which were suggested in review. Let me know if anyone has any more suggestions. |
Sorry, something went wrong.
ronag
approved these changes
Jun 21, 2020
mcollina
approved these changes
Jun 22, 2020
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
trivikr
approved these changes
Jun 22, 2020
jasnell
approved these changes
Jun 22, 2020
4 tasks
mcollina
pushed a commit
that referenced
this pull request
Jun 22, 2020
PR-URL: #33992 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
PR-URL: #33992 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33992 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be my first contribution, so please let me know if I did something wrong. Thank you!
This PR is an attempt to implement #33644
Although the issue asked I remove the old snippet, after thinking about it more I decided to keep the manual way of handling backpressure and backpressure-related errors in the docs.
Firstly, I think there may be some use case case for having to handle this manually. Secondly, having the manual way to handle this will be useful for anyone looking to gain insight as to how things work under the hood of pipeline().
I did mention pipeline() first and its benefits (that it abstracts the backpressure handling away), so I thought it was a sufficient compromise but I can remove it if ya'll think otherwise.
Checklist