doc: add a reference to the list of OpenSSL flags. - #34050
Closed
mkrawczuk wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to nodejs#33929.
jasnell
approved these changes
Jun 25, 2020
rexagod
approved these changes
Jun 26, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Jul 3, 2020
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: #34050 Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in d3d4ace |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: #34050 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: #34050 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: #34050 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Aug 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the SSL_OP_* constants are missing description in the documentation.
Instead of rewriting the description from OpenSSL's wiki, I have decided to put
a link to a detailed list in the 'OpenSSL Options' section.
I see no point of doing both - adding a reference to the wiki and adding
constant descriptions - but I might do if presented with convincing arguments.
This is a follow-up to #33929.