FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: auto start Jenkins CI via PR labels by mmarchini · Pull Request #34089 · nodejs/node · GitHub

/ node Public

build: auto start Jenkins CI via PR labels - #34089

Closed
mmarchini wants to merge 1 commit into
nodejs:masterfrom
mmarchini:auto-start-ci-via-label
ConversationCommits (1)ChecksFiles changed
Closed

build: auto start Jenkins CI via PR labels#34089
mmarchini wants to merge 1 commit into
nodejs:masterfrom
mmarchini:auto-start-ci-via-label

Conversation

mmarchini commented Jun 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add an Action that will find every PR with the request-ci label and
will start a Jenkins CI for each of these Pull Requests. The scheduler
event is used to circumvent GitHub Actions limitations on Pull Requests
from forks (where secrets are not accessible and the GITHUB_TOKEN is
read-only).

If the Action fails to start a CI, it will add a request-ci-failed
label and will leave a comment with the error message from NCU.

Requirements to land

  • Create a Jenkins token for @nodejs-github-bot
  • Add JENKINS_USER and JENKINS_TOKEN secrets to this repository (or to the entire org, if we want this to work on forks such as quic and node-auto-test as well)
  • Land ncu-ci: command to start CI for PRs node-core-utils#445 and wait for the next NCU release
  • Test more extensively on node-auto-test before landing
  • Create request-ci and request-ci-failed labels in this repository
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

mmarchini added the blocked PRs that are blocked by other issues or PRs. label Jun 27, 2020
nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jun 27, 2020
mmarchini commented Jun 27, 2020
View reviewed changes
Comment thread .github/workflows/auto-start-ci.yml Outdated
Comment on lines 55 to 62

mmarchini Jun 27, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We probably should provide a way to set ncu configs via environment variables, so we don't have to worry about writing to disk here.

mmarchini commented Jun 27, 2020
View reviewed changes
Comment thread .github/workflows/auto-start-ci.yml Outdated

mmarchini Jun 27, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If we're worried about the number of concurrent Jenkins jobs running, we could reduce this to 5 and increase the scheduler to 15-30 minutes.

mscdex commented Jun 27, 2020

Copy link
Copy Markdown
Contributor

If we add something like this, shouldn't we just get rid of the "CERTIFY_SAFE" checkbox in CI then, since there is no way to make such a confirmation explicit when applying the new label to a PR?

mmarchini commented Jun 27, 2020

Copy link
Copy Markdown
Contributor Author

That's a good question. We could consider that adding the label means the collaborator is certifying that this PR is safe (same could be said about starting a CI though)

mmarchini commented Jun 27, 2020

Copy link
Copy Markdown
Contributor Author

We could also have two labels, but that seems unnecessary

himself65 reviewed Jun 28, 2020
View reviewed changes
Comment thread .github/workflows/auto-start-ci.yml Outdated

Trott commented Jun 28, 2020

Copy link
Copy Markdown
Member

@nodejs/build

mmarchini commented Jun 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Not sure who I should ping to get consensus on adding the secrets to the repo (or if I need to do it) and to create the labels. @nodejs/tsc maybe?

Also don't know who has access to the github-bot account to create a Jenkins token for it.

mmarchini mentioned this pull request Jul 1, 2020
Closed
This was referenced Jul 25, 2020
Closed
Closed
Closed
cclauss approved these changes Jul 30, 2020
View reviewed changes

cclauss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM Impressive work!

mmarchini force-pushed the auto-start-ci-via-label branch from f1c9444 to a1121fa Compare July 30, 2020 05:41
mmarchini self-assigned this Jul 30, 2020
mmarchini removed the blocked PRs that are blocked by other issues or PRs. label Jul 30, 2020

mmarchini commented Jul 30, 2020

Copy link
Copy Markdown
Contributor Author

Ok, figured out the github-bot bits, will create the tokens on the repository before landing it.

Removed the blocked label, but it would be good to have some more reviews (especially on the general approach), I intend to land on friday or saturday to give folks a bit more time to review. I also ask to let me land it since there are other tasks that need to be accomplished while landing (create labels, add secrets to the repo)

(I'd like to land this before the commit queue since both use a similar approach, but this action won't make changes to our main branch)

phillipj reviewed Jul 30, 2020
View reviewed changes
Comment thread .github/workflows/auto-start-ci.yml Outdated
phillipj approved these changes Jul 30, 2020
View reviewed changes

phillipj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Really nice work 👍

phillipj mentioned this pull request Jul 30, 2020
Closed
mmarchini force-pushed the auto-start-ci-via-label branch from a1121fa to 9a4ae9c Compare July 30, 2020 23:07

mmarchini commented Jul 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@nodejs/build @nodejs/tsc any other reviews/comments/suggestions/objections before I land this tomorrow? (I thought about pinging collaborators but that might be too much :) )

build: auto start Jenkins CI via PR labels
84de5d9 
Add an Action that will find every PR with the `request-ci` label and
will start a Jenkins CI for each of these Pull Requests. The scheduler
event is used to circumvent GitHub Actions limitations on Pull Requests
from forks (where secrets are not accessible and the GITHUB_TOKEN is
read-only).

If the Action fails to start a CI, it will add a `request-ci-failed`
label and will leave a comment with the error message from NCU.

Fixes: nodejs/github-bot#234
mmarchini force-pushed the auto-start-ci-via-label branch from 9a4ae9c to 84de5d9 Compare July 31, 2020 22:24

mmarchini commented Jul 31, 2020

Copy link
Copy Markdown
Contributor Author

Labels created:

mmarchini added a commit that referenced this pull request Jul 31, 2020
build: auto start Jenkins CI via PR labels
6cab3b0 
Add an Action that will find every PR with the `request-ci` label and
will start a Jenkins CI for each of these Pull Requests. The scheduler
event is used to circumvent GitHub Actions limitations on Pull Requests
from forks (where secrets are not accessible and the GITHUB_TOKEN is
read-only).

If the Action fails to start a CI, it will add a `request-ci-failed`
label and will leave a comment with the error message from NCU.

Fixes: nodejs/github-bot#234

PR-URL: #34089
Reviewed-By: Christian Clauss <cclauss@me.com>

mmarchini commented Jul 31, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 6cab3b0

mmarchini closed this Jul 31, 2020
codebytere pushed a commit that referenced this pull request Aug 5, 2020
build: auto start Jenkins CI via PR labels
70cf3cb 
Add an Action that will find every PR with the `request-ci` label and
will start a Jenkins CI for each of these Pull Requests. The scheduler
event is used to circumvent GitHub Actions limitations on Pull Requests
from forks (where secrets are not accessible and the GITHUB_TOKEN is
read-only).

If the Action fails to start a CI, it will add a `request-ci-failed`
label and will leave a comment with the error message from NCU.

Fixes: nodejs/github-bot#234

PR-URL: #34089
Reviewed-By: Christian Clauss <cclauss@me.com>
codebytere mentioned this pull request Aug 10, 2020
Merged
lundibundi mentioned this pull request Aug 23, 2020
Closed
addaleax pushed a commit that referenced this pull request Sep 22, 2020
build: auto start Jenkins CI via PR labels
ae7c638 
Add an Action that will find every PR with the `request-ci` label and
will start a Jenkins CI for each of these Pull Requests. The scheduler
event is used to circumvent GitHub Actions limitations on Pull Requests
from forks (where secrets are not accessible and the GITHUB_TOKEN is
read-only).

If the Action fails to start a CI, it will add a `request-ci-failed`
label and will leave a comment with the error message from NCU.

Fixes: nodejs/github-bot#234

PR-URL: #34089
Reviewed-By: Christian Clauss <cclauss@me.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
build: auto start Jenkins CI via PR labels
e51b268 
Add an Action that will find every PR with the `request-ci` label and
will start a Jenkins CI for each of these Pull Requests. The scheduler
event is used to circumvent GitHub Actions limitations on Pull Requests
from forks (where secrets are not accessible and the GITHUB_TOKEN is
read-only).

If the Action fails to start a CI, it will add a `request-ci-failed`
label and will leave a comment with the error message from NCU.

Fixes: nodejs/github-bot#234

PR-URL: #34089
Reviewed-By: Christian Clauss <cclauss@me.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

himself65 himself65 left review comments
cclauss cclauss approved these changes
+1 more reviewer
phillipj phillipj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

mmarchini

Labels

meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL