FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: destroy wrapped streams on error by ronag · Pull Request #34102 · nodejs/node · GitHub

/ node Public

stream: destroy wrapped streams on error - #34102

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:wrap-error-destroy
ConversationCommits (1)ChecksFiles changed
Closed

stream: destroy wrapped streams on error#34102
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:wrap-error-destroy

Conversation

ronag commented Jun 28, 2020

Copy link
Copy Markdown
Member

Stream should be destroyed and update state accordingly when
the wrapped stream emits error.

Does some additional cleanup with future TODOs that might be worth
looking into.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

stream: destroy wrapped streams on error
0b80b1d 
Stream should be destroyed and update state accordingly when
the wrapped stream emits error.

Does some additional cleanup with future TODOs that might be worth
looking into.
nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Jun 28, 2020

ronag commented Jun 28, 2020

Copy link
Copy Markdown
Member Author

@nodejs/streams

ronag mentioned this pull request Jun 28, 2020
Closed
4 tasks

nodejs-github-bot commented Jun 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32132/

github-actions Bot mentioned this pull request Jun 29, 2020
Open
16 tasks
mcollina approved these changes Jun 29, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot commented Jun 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32141/

ronag requested a review from lpinca June 29, 2020 11:10
ronag added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 29, 2020

nodejs-github-bot commented Jun 29, 2020 •
edited by ronag
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32144/ ✅

ronag commented Jun 29, 2020
View reviewed changes
Comment thread lib/_stream_readable.js
this.emit('close');
});

stream.on('destroy', () => {

ronag Jun 29, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mafintosh Do you know when this happens? Or of any library that implements streams like this?

github-actions Bot mentioned this pull request Jun 30, 2020
Open
17 tasks

ronag commented Jun 30, 2020

Copy link
Copy Markdown
Member Author

Landed in 8f4b4f2

ronag closed this Jun 30, 2020
ronag added a commit that referenced this pull request Jun 30, 2020
stream: destroy wrapped streams on error
8f4b4f2 
Stream should be destroyed and update state accordingly when
the wrapped stream emits error.

Does some additional cleanup with future TODOs that might be worth
looking into.

PR-URL: #34102
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Jul 1, 2020
Open
Open
Open
Open

ronag commented Jul 4, 2020

Copy link
Copy Markdown
Member Author

Would be good to land this on all LTS versions as without this one can get unexpected unhandled exception errors.

mcollina commented Jul 4, 2020

Copy link
Copy Markdown
Member

v10.x is in maintainance so.. maybe. Getting it to v12 is definitely feasible in due time.

ronag removed the v10.x label Jul 4, 2020
github-actions Bot mentioned this pull request Jul 5, 2020
Open
31 tasks
This was referenced Jul 6, 2020
Open
Open
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
stream: destroy wrapped streams on error
2ad3ec3 
Stream should be destroyed and update state accordingly when
the wrapped stream emits error.

Does some additional cleanup with future TODOs that might be worth
looking into.

PR-URL: #34102
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
stream: destroy wrapped streams on error
41c80f6 
Stream should be destroyed and update state accordingly when
the wrapped stream emits error.

Does some additional cleanup with future TODOs that might be worth
looking into.

PR-URL: #34102
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax commented Sep 23, 2020

Copy link
Copy Markdown
Member

@ronag If this should land on v12.x, this needs a manual backport

lpinca mentioned this pull request Oct 8, 2020
Closed
4 tasks
lpinca pushed a commit to lpinca/node that referenced this pull request Oct 8, 2020
stream: destroy wrapped streams on error
4afe946 
Stream should be destroyed and update state accordingly when
the wrapped stream emits error.

Does some additional cleanup with future TODOs that might be worth
looking into.

PR-URL: nodejs#34102
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
stream: destroy wrapped streams on error
e40b78c 
Stream should be destroyed and update state accordingly when
the wrapped stream emits error.

Does some additional cleanup with future TODOs that might be worth
looking into.

Backport-PR-URL: #35557
PR-URL: #34102
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
stream: destroy wrapped streams on error
8a10916 
Stream should be destroyed and update state accordingly when
the wrapped stream emits error.

Does some additional cleanup with future TODOs that might be worth
looking into.

Backport-PR-URL: #35557
PR-URL: #34102
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL