test: fix flaky test for symlinks - #3418
Closed
Trott wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
how about returning SKIP for this case? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It only skips the fs.symlink() test, but it still performs the fs.link() test. So if we wanted to do that, we would have to split this test into two different test files. Which, actually, makes a lot of sense... |
Sorry, something went wrong.
If the symlink portion of the test was being skipped due to a combination of OS support and user privileges, then an assertion would always fail. This fixes that problem, improves assertion error reporting and renames the test to make it clear that it is a test for links and not just symlinks. Fixes: nodejs#3311
Trott
force-pushed
the
win10-fs-symlink
branch
from
60ebd95 to
193c6b2
Compare
October 18, 2015 05:32
Copy link
Copy Markdown
Member
Author
|
@jbergstroem Test is now split into two files, one for fs.link() and one for fs.symlink(). When the symlink test is skipped it now outputs a TAP skip. PTAL |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Trott
added a commit
that referenced
this pull request
Oct 20, 2015
If the symlink portion of the test was being skipped due to a combination of OS support and user privileges, then an assertion would always fail. This fixes that problem, improves assertion error reporting and splits the test to make it clear that it is a test for links and symlinks. Fixes: #3311 PR-URL: #3418 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Trott
added a commit
that referenced
this pull request
Oct 21, 2015
If the symlink portion of the test was being skipped due to a combination of OS support and user privileges, then an assertion would always fail. This fixes that problem, improves assertion error reporting and splits the test to make it clear that it is a test for links and symlinks. Fixes: #3311 PR-URL: #3418 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Trott
added a commit
that referenced
this pull request
Oct 26, 2015
If the symlink portion of the test was being skipped due to a combination of OS support and user privileges, then an assertion would always fail. This fixes that problem, improves assertion error reporting and splits the test to make it clear that it is a test for links and symlinks. Fixes: #3311 PR-URL: #3418 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Trott
added a commit
that referenced
this pull request
Oct 29, 2015
If the symlink portion of the test was being skipped due to a combination of OS support and user privileges, then an assertion would always fail. This fixes that problem, improves assertion error reporting and splits the test to make it clear that it is a test for links and symlinks. Fixes: #3311 PR-URL: #3418 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3311