FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove flaky status from eval_messages test by Trott · Pull Request #3420 · nodejs/node · GitHub

/ node Public

test: remove flaky status from eval_messages test - #3420

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:eval_messages
ConversationCommits (1)ChecksFiles changed
Closed

test: remove flaky status from eval_messages test#3420
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:eval_messages

Conversation

Trott commented Oct 18, 2015

Copy link
Copy Markdown
Member

This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: #2672

test: remove flaky status from eval_messages test
486349c 
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: nodejs#2672

Trott commented Oct 18, 2015

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/868/

mscdex added the test Issues and PRs related to the tests. label Oct 18, 2015

rvagg commented Oct 19, 2015

Copy link
Copy Markdown
Member

lgtm

Fishrock123 commented Oct 19, 2015

Copy link
Copy Markdown
Contributor

LGTM

orangemocha commented Oct 19, 2015

Copy link
Copy Markdown
Contributor

I agree based on the findings you mentioned that this test would be more useful without the flaky status. Even better diligence would be to run this test in a loop and see if the intermittent failures can be reproduced. Locally on a linux box, or in CI with a special test run. I can get to it later this week.

jasnell commented Oct 20, 2015

Copy link
Copy Markdown
Member

LGTM

Trott added a commit that referenced this pull request Oct 20, 2015
test: remove flaky status from eval_messages test
7cb89f5 
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: #2672
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3420

jasnell commented Oct 20, 2015

Copy link
Copy Markdown
Member

Landed in 7cb89f5

jasnell closed this Oct 20, 2015
Trott added a commit that referenced this pull request Oct 21, 2015
test: remove flaky status from eval_messages test
eef0f0c 
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: #2672
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3420
rvagg mentioned this pull request Oct 21, 2015
Merged
Trott added a commit that referenced this pull request Oct 26, 2015
test: remove flaky status from eval_messages test
0c23e81 
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: #2672
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3420

jasnell commented Oct 26, 2015

Copy link
Copy Markdown
Member

Landed in v4.x-staging in 0c23e81

rvagg mentioned this pull request Oct 28, 2015
Closed
Trott added a commit that referenced this pull request Oct 29, 2015
test: remove flaky status from eval_messages test
eac2acc 
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: #2672
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3420
snyk-bot mentioned this pull request Aug 10, 2020
Closed
Trott deleted the eval_messages branch January 13, 2022 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL