FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[12.x] fs: Backport eadc385, fix for fsPromises.truncate by jasnell · Pull Request #34239 · nodejs/node · GitHub

/ node Public

[12.x] fs: Backport eadc385, fix for fsPromises.truncate - #34239

Closed
jasnell wants to merge 1 commit into
nodejs:v12.x-stagingfrom
jasnell:cherry-pick-eadc385
ConversationCommits (1)ChecksFiles changed
Closed

[12.x] fs: Backport eadc385, fix for fsPromises.truncate#34239
jasnell wants to merge 1 commit into
nodejs:v12.x-stagingfrom
jasnell:cherry-pick-eadc385

Conversation

jasnell commented Jul 7, 2020

Copy link
Copy Markdown
Member

Fixes: #34189

fsPromises.truncate() was not closing the opened FileHandle.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

fs: close file descriptor of promisified truncate
2073a78 
PR-URL: nodejs#28858
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. v12.x labels Jul 7, 2020
jasnell requested a review from richardlau July 7, 2020 14:04

richardlau commented Jul 7, 2020

Copy link
Copy Markdown
Member

Will this also need to be backported to 10.x?

jasnell commented Jul 7, 2020

Copy link
Copy Markdown
Member Author

Will this also need to be backported to 10.x?

Possibly, Likely.

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 7, 2020

nodejs-github-bot commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32237/

jasnell pushed a commit that referenced this pull request Jul 9, 2020
fs: close file descriptor of promisified truncate
04fa6d6 
Original PR:
  PR-URL: #28858
  Reviewed-By: Rich Trott <rtrott@gmail.com>
  Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #34239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

jasnell commented Jul 9, 2020

Copy link
Copy Markdown
Member Author

Landed in 04fa6d6

jasnell closed this Jul 9, 2020
pittst3r mentioned this pull request Jul 13, 2020
Merged
codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
fs: close file descriptor of promisified truncate
7aac983 
Original PR:
  PR-URL: #28858
  Reviewed-By: Rich Trott <rtrott@gmail.com>
  Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #34239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
richardlau richardlau approved these changes
Flarna Flarna approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL