doc: introduce a triager role - #34295
Closed
gireeshpunathil wants to merge 0 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Optional idea, but maybe specify that someone should participate (leave comments on issues, for example) in the repository for a while before applying? I imagine we're unlikely to give the role to people we haven't seen interact in the repository. These are going to be people that will be the first to interact with new folks posting issues and PRs. We'll want to see some evidence that they understand Node.js and our process, but also that they interact with kindness and patience. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@Trott - thanks, added a phrase to that effect, PTAL! |
Sorry, something went wrong.
Trott
reviewed
Jul 17, 2020
Comment thread
doc/guides/contributing/issues.md
Outdated
Trott
reviewed
Jul 17, 2020
Comment thread
doc/guides/contributing/issues.md
Outdated
Trott
reviewed
Jul 17, 2020
Comment thread
doc/guides/contributing/issues.md
Outdated
Trott
reviewed
Jul 17, 2020
Comment thread
doc/guides/contributing/issues.md
Outdated
Trott
reviewed
Jul 17, 2020
Comment thread
doc/guides/contributing/issues.md
Outdated
Trott
reviewed
Jul 17, 2020
Comment thread
doc/guides/contributing/issues.md
Outdated
Trott
reviewed
Jul 17, 2020
Comment thread
doc/guides/contributing/issues.md
Outdated
Trott
reviewed
Jul 17, 2020
Comment thread
doc/guides/contributing/issues.md
Outdated
Trott
reviewed
Jul 17, 2020
Comment thread
doc/guides/contributing/issues.md
Outdated
Trott
approved these changes
Jul 17, 2020
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. I left a bunch of style suggestions, but none of them are blocking/required.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@Trott - thanks, accommodated all those style suggestions. |
Sorry, something went wrong.
jasnell
approved these changes
Jul 17, 2020
trivikr
approved these changes
Jul 17, 2020
targos
approved these changes
Jul 18, 2020
Copy link
Copy Markdown
Member
|
Do we want to update GOVERNANCE.md to mention the triager role? (It doesn't have to happen in this PR, and can even be decided at a later date.) |
Sorry, something went wrong.
gireeshpunathil
added a commit
that referenced
this pull request
Jul 19, 2020
The role helps triaging issue backlogs effectively Fixes: #34054 Refs: nodejs/TSC#891 PR-URL: #34295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
4 tasks
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
The role helps triaging issue backlogs effectively Fixes: #34054 Refs: nodejs/TSC#891 PR-URL: #34295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gireeshpunathil
added a commit
that referenced
this pull request
Jul 24, 2020
Refs: #34295 (comment) PR-URL: #34426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
The role helps triaging issue backlogs effectively Fixes: #34054 Refs: nodejs/TSC#891 PR-URL: #34295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
Refs: #34295 (comment) PR-URL: #34426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
4 tasks
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
The role helps triaging issue backlogs effectively Fixes: #34054 Refs: nodejs/TSC#891 PR-URL: #34295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Refs: #34295 (comment) PR-URL: #34426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
The role helps triaging issue backlogs effectively Fixes: #34054 Refs: nodejs/TSC#891 PR-URL: #34295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Refs: #34295 (comment) PR-URL: #34426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The role helps triaging issue backlogs effectively.
Fixes: #34054
Refs: nodejs/TSC#891
Checklist