FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: make node-gyp fetch tarballs from iojs.org by bnoordhuis · Pull Request #343 · nodejs/node · GitHub

/ node Public

deps: make node-gyp fetch tarballs from iojs.org - #343

Merged
bnoordhuis merged 1 commit into
nodejs:v1.xfrom
bnoordhuis:fix-node-gyp
Jan 13, 2015
Merged

deps: make node-gyp fetch tarballs from iojs.org#343
bnoordhuis merged 1 commit into
nodejs:v1.xfrom
bnoordhuis:fix-node-gyp

Conversation

Copy link
Copy Markdown
Member

Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

R=@rvagg

Note that /dist doesn't currently exist.

rvagg commented Jan 13, 2015

Copy link
Copy Markdown
Member

I'll see if I can test this locally to be sure

rvagg commented Jan 13, 2015

Copy link
Copy Markdown
Member

beautiful / lgtm:

$ npm -v && node -v && iojs -v && iojs -pe process.versions
2.1.18
v1.0.0
v1.0.0
{ http_parser: '2.3',
  node: '1.0.0',
  v8: '3.31.74.1',
  uv: '1.2.0',
  zlib: '1.2.8',
  modules: '42',
  openssl: '1.0.1k' }
$ npm install leveldown
npm http request GET https://registry.npmjs.org/leveldown
npm http 304 https://registry.npmjs.org/leveldown
npm http request GET https://registry.npmjs.org/abstract-leveldown
npm http request GET https://registry.npmjs.org/fast-future
npm http request GET https://registry.npmjs.org/bindings
npm http request GET https://registry.npmjs.org/nan
npm http 304 https://registry.npmjs.org/bindings
npm http 304 https://registry.npmjs.org/nan
npm http 304 https://registry.npmjs.org/abstract-leveldown
npm http 304 https://registry.npmjs.org/fast-future
npm http request GET https://registry.npmjs.org/xtend
npm http 304 https://registry.npmjs.org/xtend

> leveldown@1.0.0 install /tmp/node_modules/leveldown
> node-gyp rebuild

gyp http GET https://iojs.org/dist/v1.0.0/iojs-v1.0.0.tar.gz
gyp http 200 https://iojs.org/dist/v1.0.0/iojs-v1.0.0.tar.gz
gyp http GET https://iojs.org/dist/v1.0.0/SHASUMS256.txt
gyp http 200 https://iojs.org/dist/v1.0.0/SHASUMS256.txt
child_process: customFds option is deprecated, use stdio instead.
make: Entering directory '/tmp/node_modules/leveldown/build'
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/builder.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/db_impl.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/db_iter.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/filename.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/dbformat.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/memtable.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/table/block_builder.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/log_reader.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/log_writer.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/repair.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/table_cache.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/helpers/memenv/memenv.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/version_edit.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/table/block.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/write_batch.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/db/version_set.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/table/format.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/table/filter_block.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/table/table.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/bloom.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/table/table_builder.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/table/two_level_iterator.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/arena.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/table/merger.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/table/iterator.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/cache.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/coding.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/comparator.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/crc32c.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/env.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/filter_policy.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/hash.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/logging.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/options.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/status.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/port/port_posix.o
  CXX(target) Release/obj.target/leveldb/deps/leveldb/leveldb-1.17.0/util/env_posix.o
  CXX(target) Release/obj.target/snappy/deps/snappy/snappy-1.1.1/snappy-sinksource.o
  CXX(target) Release/obj.target/snappy/deps/snappy/snappy-1.1.1/snappy-stubs-internal.o
  CXX(target) Release/obj.target/snappy/deps/snappy/snappy-1.1.1/snappy.o
  AR(target) Release/obj.target/deps/snappy/snappy.a
  COPY Release/snappy.a
  AR(target) Release/obj.target/deps/leveldb/leveldb.a
  COPY Release/leveldb.a
  CXX(target) Release/obj.target/leveldown/src/batch.o
  CXX(target) Release/obj.target/leveldown/src/batch_async.o
  CXX(target) Release/obj.target/leveldown/src/database.o
  CXX(target) Release/obj.target/leveldown/src/database_async.o
  CXX(target) Release/obj.target/leveldown/src/iterator.o
  CXX(target) Release/obj.target/leveldown/src/iterator_async.o
  CXX(target) Release/obj.target/leveldown/src/leveldown_async.o
  CXX(target) Release/obj.target/leveldown/src/leveldown.o
In file included from ../src/leveldown.h:11:0,
                 from ../src/leveldown.cc:8:
../node_modules/nan/nan.h:481:19: error: ‘NanNew’ declared as an ‘inline’ variable
       v8::String::ExternalAsciiStringResource *resource) {

etc. etc. about v8::String::ExternalAsciiStringResource predictably.

$ rm -rf ~/.node-gyp/1.0.0/
$ npm install buffertools
npm http request GET https://registry.npmjs.org/buffertools
npm http 304 https://registry.npmjs.org/buffertools

> buffertools@2.1.2 install /tmp/node_modules/buffertools
> node-gyp rebuild

gyp http GET https://iojs.org/dist/v1.0.0/iojs-v1.0.0.tar.gz
gyp http 200 https://iojs.org/dist/v1.0.0/iojs-v1.0.0.tar.gz
gyp http GET https://iojs.org/dist/v1.0.0/SHASUMS256.txt
gyp http 200 https://iojs.org/dist/v1.0.0/SHASUMS256.txt
child_process: customFds option is deprecated, use stdio instead.
make: Entering directory '/tmp/node_modules/buffertools/build'
  CXX(target) Release/obj.target/buffertools/buffertools.o
  SOLINK_MODULE(target) Release/obj.target/buffertools.node
  SOLINK_MODULE(target) Release/obj.target/buffertools.node: Finished
  COPY Release/buffertools.node
make: Leaving directory '/tmp/node_modules/buffertools/build'
buffertools@2.1.2 node_modules/buffertools

Now I'm kind of excited!

/cc @kkoopa FYI

Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: nodejs#343
Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis merged commit 03d1992 into nodejs:v1.x Jan 13, 2015
bnoordhuis deleted the fix-node-gyp branch January 13, 2015 23:39

wavded commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

Did this land in 1.0.0? It is still fetching from nodejs.org for me.

rvagg commented Jan 14, 2015

Copy link
Copy Markdown
Member

grab 1.0.1, just landed, has proper fixes in it

wavded commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

thanks!

othiym23 pushed a commit to npm/node that referenced this pull request Jan 18, 2015
Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: nodejs#343
Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis added a commit that referenced this pull request Jan 18, 2015
Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: #343
Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis added a commit that referenced this pull request Jan 23, 2015
Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: #343
Reviewed-By: Rod Vagg <rod@vagg.org>
othiym23 pushed a commit to npm/node that referenced this pull request Jan 30, 2015
Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: nodejs#343
Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis added a commit that referenced this pull request Jan 31, 2015
Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: #343
Reviewed-By: Rod Vagg <rod@vagg.org>
othiym23 pushed a commit to npm/node that referenced this pull request Feb 6, 2015
Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: nodejs#343
Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis added a commit that referenced this pull request Feb 6, 2015
Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: #343
Reviewed-By: Rod Vagg <rod@vagg.org>
othiym23 pushed a commit to npm/node that referenced this pull request Feb 20, 2015
Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: nodejs#343
Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis added a commit that referenced this pull request Feb 22, 2015
Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: #343
Reviewed-By: Rod Vagg <rod@vagg.org>
This was referenced Feb 23, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL