FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test,tools: use `.then(common.mustCall())` for all async IIFEs + linter rule by addaleax · Pull Request #34363 · nodejs/node · GitHub

/ node Public

test,tools: use .then(common.mustCall()) for all async IIFEs + linter rule - #34363

Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:async-iife-fix
ConversationCommits (3)ChecksFiles changed
Closed

test,tools: use .then(common.mustCall()) for all async IIFEs + linter rule#34363
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:async-iife-fix

Conversation

addaleax commented Jul 14, 2020

Copy link
Copy Markdown
Member
test: use .then(common.mustCall()) for all async IIFEs

This makes sure that all async functions finish as expected.

tools: add linting rule for async IIFEs

The result of an async IIFE should always be handled in our tests,
typically by adding .then(common.mustCall()) to verify that the
async function actually finishes executing at some point.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

addaleax added 2 commits July 14, 2020 17:56
test: use .then(common.mustCall()) for all async IIFEs
ee5488d 
This makes sure that all async functions finish as expected.
tools: add linting rule for async IIFEs
1c91794 
The result of an async IIFE should always be handled in our tests,
typically by adding `.then(common.mustCall())` to verify that the
async function actually finishes executing at some point.
nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. test Issues and PRs related to the tests. labels Jul 14, 2020
addaleax added tools Issues and PRs related to the tools directory. and removed esm Issues and PRs related to the ECMAScript Modules implementation. labels Jul 14, 2020

addaleax commented Jul 14, 2020

Copy link
Copy Markdown
Member Author

Don’t think there’s a team for eslint stuff, so /cc @cjihrig @Trott I guess?

nodejs-github-bot commented Jul 14, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32339/

cjihrig commented Jul 14, 2020

Copy link
Copy Markdown
Contributor

Don’t think there’s a team for eslint stuff

There is @nodejs/linting.

nodejs-github-bot commented Jul 14, 2020 •
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32344/ (:green_heart:)

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 15, 2020
addaleax added a commit that referenced this pull request Jul 20, 2020
test: use .then(common.mustCall()) for all async IIFEs
2c4ebe0 
This makes sure that all async functions finish as expected.

PR-URL: #34363
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax added a commit that referenced this pull request Jul 20, 2020
tools: add linting rule for async IIFEs
77b68f9 
The result of an async IIFE should always be handled in our tests,
typically by adding `.then(common.mustCall())` to verify that the
async function actually finishes executing at some point.

PR-URL: #34363
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax commented Jul 20, 2020

Copy link
Copy Markdown
Member Author

Landed in da95dd7...77b68f9

addaleax closed this Jul 20, 2020
addaleax deleted the async-iife-fix branch July 20, 2020 16:15

ruyadorno commented Jul 22, 2020

Copy link
Copy Markdown
Member

This don't land cleanly on v14.x should it be backported?

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
test: use .then(common.mustCall()) for all async IIFEs
fd0096d 
This makes sure that all async functions finish as expected.

PR-URL: #34363
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
tools: add linting rule for async IIFEs
f5363e4 
The result of an async IIFE should always be handled in our tests,
typically by adding `.then(common.mustCall())` to verify that the
async function actually finishes executing at some point.

PR-URL: #34363
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added backported-to-v14.x and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. backport-requested-v14.x labels May 16, 2021
targos pushed a commit that referenced this pull request May 16, 2021
test: use .then(common.mustCall()) for all async IIFEs
845f3ae 
This makes sure that all async functions finish as expected.

PR-URL: #34363
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request May 16, 2021
tools: add linting rule for async IIFEs
02233af 
The result of an async IIFE should always be handled in our tests,
typically by adding `.then(common.mustCall())` to verify that the
async function actually finishes executing at some point.

PR-URL: #34363
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
test: use .then(common.mustCall()) for all async IIFEs
89ee6ab 
This makes sure that all async functions finish as expected.

PR-URL: #34363
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
tools: add linting rule for async IIFEs
9fa8d20 
The result of an async IIFE should always be handled in our tests,
typically by adding `.then(common.mustCall())` to verify that the
async function actually finishes executing at some point.

PR-URL: #34363
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
snyk-bot mentioned this pull request Sep 13, 2022
Open
ron-a20 mentioned this pull request Sep 13, 2022
Open
This was referenced Sep 13, 2022
Open
Open
wedataintelligence mentioned this pull request Sep 13, 2022
Open
snyk-bot mentioned this pull request Sep 13, 2022
Open
molllyn1 mentioned this pull request Sep 14, 2022
Open
137717unity mentioned this pull request Sep 14, 2022
Open
snyk-bot mentioned this pull request Sep 25, 2022
Open
wedataintelligence mentioned this pull request Sep 26, 2022
Open
137717unity mentioned this pull request Sep 26, 2022
Open
snyk-bot mentioned this pull request Sep 27, 2022
Open
wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
snyk-bot mentioned this pull request Oct 6, 2022
Open
137717unity mentioned this pull request Oct 7, 2022
Open
wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
137717unity mentioned this pull request Oct 9, 2022
Open
snyk-bot mentioned this pull request Oct 9, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL