FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add writable and readable options to Duplex docs by preyunk · Pull Request #34383 · nodejs/node · GitHub

/ node Public

doc: add writable and readable options to Duplex docs - #34383

Closed
preyunk wants to merge 1 commit into
nodejs:masterfrom
preyunk:add-doc-duplex
ConversationCommits (1)ChecksFiles changed
Closed

doc: add writable and readable options to Duplex docs#34383
preyunk wants to merge 1 commit into
nodejs:masterfrom
preyunk:add-doc-duplex

Conversation

preyunk commented Jul 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #34382

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jul 15, 2020

preyunk commented Jul 15, 2020

Copy link
Copy Markdown
Contributor Author

ping @ronag

ronag approved these changes Jul 15, 2020
View reviewed changes

ronag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

nodejs-github-bot commented Aug 9, 2020 •
edited by rickyes
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32693/ ✅

ronag added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 9, 2020
rickyes pushed a commit that referenced this pull request Aug 10, 2020
doc: add writable and readable options to Duplex docs
3ddf2c9 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

rickyes commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

Landed in 3ddf2c9

@preyunk congratulations on your first commit to Node.js! 🎉

rickyes closed this Aug 10, 2020

preyunk commented Aug 10, 2020

Copy link
Copy Markdown
Contributor Author

@rickyes Thanks, looking forward to contribute more.

MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
doc: add writable and readable options to Duplex docs
4377690 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
doc: add writable and readable options to Duplex docs
b93ba07 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
doc: add writable and readable options to Duplex docs
2260037 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
doc: add writable and readable options to Duplex docs
0ba9052 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
ronag ronag approved these changes
juanarbol juanarbol approved these changes
+3 more reviewers
antsmartian antsmartian approved these changes
willin willin approved these changes
rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add 'writable' and 'readable' to 'new stream.Duplex(options)' docs.

9 participants

Back | FazBrowse Home | New Git URL