FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: add missing shell option to execSync by claudiorodriguez · Pull Request #3440 · nodejs/node · GitHub

/ node Public

docs: add missing shell option to execSync - #3440

Closed
claudiorodriguez wants to merge 1 commit into
nodejs:masterfrom
claudiorodriguez:doc-child-process-execsync-missing-shell-option
ConversationCommits (1)ChecksFiles changed
Closed

docs: add missing shell option to execSync#3440
claudiorodriguez wants to merge 1 commit into
nodejs:masterfrom
claudiorodriguez:doc-child-process-execsync-missing-shell-option

Conversation

claudiorodriguez commented Oct 19, 2015

Copy link
Copy Markdown
Contributor

Adds the "shell" option from child_process.exec to child_process.execSync on the api docs. Issue #3387

Fishrock123 added the doc Issues and PRs related to the documentations. label Oct 19, 2015
mscdex added the child_process Issues and PRs related to the child_process subsystem. label Oct 19, 2015

jasnell commented Oct 19, 2015

Copy link
Copy Markdown
Member

LGTM

MylesBorins commented Oct 19, 2015

Copy link
Copy Markdown
Contributor

@jasnell LTS?

jasnell commented Oct 19, 2015

Copy link
Copy Markdown
Member

@thealphanerd ... +1

cjihrig commented Oct 20, 2015

Copy link
Copy Markdown
Contributor

LGTM

Trott commented Oct 20, 2015

Copy link
Copy Markdown
Member

Nit: first line of commit log message should be less than 50 chars (no big deal if you don't fix it, whoever merges it can fix it, but you'd be saving someone a step)

claudiorodriguez changed the title docs: child_process: adds missing shell option to execSync #3387 docs: add missing shell option to execSync Oct 20, 2015
claudiorodriguez force-pushed the doc-child-process-execsync-missing-shell-option branch from e6f0852 to 1c2f9dd Compare October 20, 2015 13:18

claudiorodriguez commented Oct 20, 2015

Copy link
Copy Markdown
Contributor Author

@Trott Whoops, I'll have to keep that in mind. Fixed. Thanks!

jasnell pushed a commit that referenced this pull request Oct 20, 2015
docs: add missing shell option to execSync
49f965c 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #3440

jasnell commented Oct 20, 2015

Copy link
Copy Markdown
Member

Landed in 49f965c

jasnell closed this Oct 20, 2015
rvagg pushed a commit that referenced this pull request Oct 21, 2015
docs: add missing shell option to execSync
47b06f6 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #3440
rvagg mentioned this pull request Oct 21, 2015
Merged
jasnell pushed a commit that referenced this pull request Oct 26, 2015
docs: add missing shell option to execSync
47ab7c7 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #3440

jasnell commented Oct 26, 2015

Copy link
Copy Markdown
Member

Landed in v4.x-staging in 47ab7c7

rvagg mentioned this pull request Oct 28, 2015
Closed
jasnell pushed a commit that referenced this pull request Oct 29, 2015
docs: add missing shell option to execSync
9120a04 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #3440
leonardoadame mentioned this pull request Nov 28, 2023
Open
aliscco mentioned this pull request Nov 28, 2023
Open
leonardoadame mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 29, 2023
Open
Open
leonardoadame mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 29, 2023
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL