Revert "module: fix check for package.json at volume root" - #34403
Revert "module: fix check for package.json at volume root"#34403MylesBorins wants to merge 1 commit into
Conversation
Sorry, something went wrong.
This reverts commit 51af89f. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: * coffeescript * JSONStream * gulp * and more We should reopen a PR to figure out how to land this in a way that is non-breaking. Refs: nodejs#33476
|
Can you please share link to the regressions caused by the commit being reverted? |
Sorry, something went wrong.
Yes, I would be interested in that as well. Is there a permalink for the aforementioned CITGM failures that justify this change? |
Sorry, something went wrong.
I hope to find time to fix this, but probably not for several days. If anyone has time to take a crack at redoing the reverted PR before then, please let us know so that we don't duplicate effort. |
Sorry, something went wrong.
A testing strategy for this would be very helpful. @GeoffreyBooth, I'll catch up w/ you in a few days to see about reworking that Docker strategy you came up with for the .mjs server stuff. Until then, this should obviously be reverted. |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
This reverts commit 51af89f. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: * coffeescript * JSONStream * gulp * and more We should reopen a PR to figure out how to land this in a way that is non-breaking. Refs: #33476 PR-URL: #34403 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This reverts commit 51af89f. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: * coffeescript * JSONStream * gulp * and more We should reopen a PR to figure out how to land this in a way that is non-breaking. Refs: #33476 PR-URL: #34403 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This reverts commit 51af89f.
This has needed to be backed out of both the 14.5.0 and 14.6.0
releases due to creating regressions across multiple projects
including:
We should reopen a PR to figure out how to land this in a way
that is non-breaking.
Refs: #33476