doc: binary encoding is not deprecated - #3441
Closed
trevnorris wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
doc/api/buffer.markdown
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'd reword this a little so people won't think buf.toString('latin-1') is a thing.
Sorry, something went wrong.
When v8 implemented proper one-byte string support Node's internal "binary" encoding implementation was removed in favor of it. The result was that "binary" encoding effectively became "latin-1" encoding. Because of this and because one-byte strings are natively supported by v8 the buffer encoding is not deprecated and will not be removed. Ref: 83261e7 "deps: update v8 to 3.17.13"
trevnorris
force-pushed
the
binary-not-deprecated
branch
from
a109c34 to
528dd30
Compare
October 19, 2015 23:04
Copy link
Copy Markdown
Contributor
Author
|
@bnoordhuis Good call. I gave it another go. Though feel like I wasn't able to convey the info w/o being too specific. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
trevnorris
added a commit
that referenced
this pull request
Oct 20, 2015
When v8 implemented proper one-byte string support Node's internal "binary" encoding implementation was removed in favor of it. The result was that "binary" encoding effectively became "latin-1" encoding. Because of this and because one-byte strings are natively supported by v8 the buffer encoding is not deprecated and will not be removed. Ref: 83261e7 "deps: update v8 to 3.17.13" PR-URL: #3441 Reviewed-By: Ben Noordhuis <ben@strongloop.com>
Copy link
Copy Markdown
Contributor
Author
|
Thanks much. Landed in 57f99a9. |
Sorry, something went wrong.
trevnorris
added a commit
that referenced
this pull request
Oct 21, 2015
When v8 implemented proper one-byte string support Node's internal "binary" encoding implementation was removed in favor of it. The result was that "binary" encoding effectively became "latin-1" encoding. Because of this and because one-byte strings are natively supported by v8 the buffer encoding is not deprecated and will not be removed. Ref: 83261e7 "deps: update v8 to 3.17.13" PR-URL: #3441 Reviewed-By: Ben Noordhuis <ben@strongloop.com>
trevnorris
added a commit
that referenced
this pull request
Oct 21, 2015
When v8 implemented proper one-byte string support Node's internal "binary" encoding implementation was removed in favor of it. The result was that "binary" encoding effectively became "latin-1" encoding. Because of this and because one-byte strings are natively supported by v8 the buffer encoding is not deprecated and will not be removed. Ref: 83261e7 "deps: update v8 to 3.17.13" PR-URL: #3441 Reviewed-By: Ben Noordhuis <ben@strongloop.com>
This was referenced Oct 28, 2015
trevnorris
added a commit
that referenced
this pull request
Oct 30, 2015
When v8 implemented proper one-byte string support Node's internal "binary" encoding implementation was removed in favor of it. The result was that "binary" encoding effectively became "latin-1" encoding. Because of this and because one-byte strings are natively supported by v8 the buffer encoding is not deprecated and will not be removed. Ref: 83261e7 "deps: update v8 to 3.17.13" PR-URL: #3441 Reviewed-By: Ben Noordhuis <ben@strongloop.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When v8 implemented proper one-byte string support Node's internal
"binary" encoding implementation was removed in favor of it. The result
was that "binary" encoding effectively became "latin-1" encoding.
Because of this and because one-byte strings are natively supported by
v8 the buffer encoding is not deprecated and will not be removed.
Ref: 83261e7 "deps: update v8 to 3.17.13"
R=@bnoordhuis