FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v12.x backport] Forces Powershell to use tls1.2 by bzoz · Pull Request #34462 · nodejs/node · GitHub

/ node Public

[v12.x backport] Forces Powershell to use tls1.2 - #34462

Closed
bzoz wants to merge 1 commit into
nodejs:v12.x-stagingfrom
JaneaSystems:backport-v12-33609
Closed

[v12.x backport] Forces Powershell to use tls1.2#34462
bzoz wants to merge 1 commit into
nodejs:v12.x-stagingfrom
JaneaSystems:backport-v12-33609

Conversation

bzoz commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: #33140
PR-URL: #33609
Reviewed-By: Bartosz Sosnowski bartosz@janeasystems.com
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com
Reviewed-By: Tobias Nießen tniessen@tnie.de

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. v12.x windows Issues and PRs related to the Windows platform. labels Jul 21, 2020

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor

@bzoz looks like this needs a rebase, tried to do it myself but it would let me push to the branch

Copy link
Copy Markdown
Contributor

This has not yet gone out in a current release, so we need to wait a bit to backport to 12

bzoz commented Aug 18, 2020

Copy link
Copy Markdown
Contributor Author

Rebased

bzoz requested a review from a team as a September 22, 2020 08:48
addaleax force-pushed the v12.x-staging branch 4 times, most recently from 55fe022 to 65b7bf4 Compare September 22, 2020 17:57

Copy link
Copy Markdown
Member

@bzoz Sorry to ask, but could you rebase again?

Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: nodejs#33140
PR-URL: nodejs#33609
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
bzoz force-pushed the backport-v12-33609 branch from a3a4e44 to a5282dd Compare September 23, 2020 08:39

bzoz commented Sep 23, 2020

Copy link
Copy Markdown
Contributor Author

@addaleax done!

addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2020

Copy link
Copy Markdown
Collaborator

addaleax pushed a commit that referenced this pull request Sep 23, 2020
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: #33140
PR-URL: #33609
Backport-PR-URL: #34462
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Copy link
Copy Markdown
Member

Landed in 27ceec0

(I left the commit message as-is, to be consistent with the decision for v14.x: #34461 (comment))

bzoz closed this Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL