FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "src: simplify format in node_file.cc" by MylesBorins · Pull Request #34463 · nodejs/node · GitHub

/ node Public

Revert "src: simplify format in node_file.cc" - #34463

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:revert-33660
ConversationCommits (1)ChecksFiles changed
Closed

Revert "src: simplify format in node_file.cc"#34463
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:revert-33660

Conversation

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

This reverts commit 673f49a.

This change is breaking gulp on v14.x. Reverting so we can reland in a
way that doesn't break stuff

Refs: #33660
Refs: #34371

Revert "src: simplify format in node_file.cc"
4761579 
This reverts commit 673f49a.

This change is breaking gulp on v14.x. Reverting so we can reland in a
way that doesn't break stuff

Refs: nodejs#33660
Refs: nodejs#34371
MylesBorins requested a review from himself65 July 21, 2020 17:25
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Jul 21, 2020

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

@himself65 FYI

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

Can we please fast track so we can get this in 14.6.0

MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 21, 2020

nodejs-github-bot commented Jul 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32443/

addaleax commented Jul 21, 2020

Copy link
Copy Markdown
Member

… this is very surprising – it’s purely a formatting change. If this breaks gulp, then gulp is already broken, but it seems almost impossible that this change actually affects behavior in anyway.

If you are certain that this is breaking, maybe just leave the commit out of the v14.6.0 proposal?

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

@addaleax this change went out in v14.5.0 and broke the gulp test suite. Reverting this change in v14.6.0 fixes it.

I'll admit that I am also surprised that this change is having that effect. Although honestly I just ran the test suite again and this revert was not fixing it... TBH I'm very confused right now and will dig in a bit more

addaleax commented Jul 21, 2020

Copy link
Copy Markdown
Member

@MylesBorins Maybe some other change made the test suite flaky? I think that seems like a more likely cause…

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

there is definitely a change on 14.5.0 that broke gulp, perhaps this was a false positive from bisect

Running bisect again and a few more manual tests... since when I checked again this revert didn't actually fix the problem I was seeing

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

Closing as manual testing again on local machine shows gulp still failing

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

himself65 Awaiting requested review from himself65

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL